From a21ec3ca3a6e394ef3cb226473fd105832893fdf Mon Sep 17 00:00:00 2001
From: RTHPJM <rthpjm@mac.com>
Date: Tue, 11 Apr 2023 14:27:14 +0100
Subject: [PATCH 1/5] Update extract-7z.rb

---
 src/extract-7z.rb | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/src/extract-7z.rb b/src/extract-7z.rb
index f33a9c4..bf1863e 100644
--- a/src/extract-7z.rb
+++ b/src/extract-7z.rb
@@ -17,10 +17,18 @@ def self.p7zip file
       begin
         line = Terrapin::CommandLine.new("7z", "l :file | grep 'Type = 7z'")
         line.run(file: file)
-        true
+        result_7Z = true
       rescue Terrapin::ExitStatusError => e
-        false
+        result_7Z = false
       end
+      begin
+        line = Terrapin::CommandLine.new("7z", "l :file | grep 'Type = Cab'")
+        line.run(file: file)
+        result_Cab = true
+      rescue Terrapin::ExitStatusError => e
+        result_Cab = false
+      end
+      return result_Cab || result_7z
     end
   end
-end
\ No newline at end of file
+end

From 965112be7d63bff4f9464e35b56c7762c007115f Mon Sep 17 00:00:00 2001
From: RTHPJM <rthpjm@mac.com>
Date: Wed, 12 Apr 2023 10:03:01 +0100
Subject: [PATCH 2/5] Update README.md

---
 README.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/README.md b/README.md
index bd380d1..0b074c9 100644
--- a/README.md
+++ b/README.md
@@ -3,6 +3,8 @@
 This tool attempts to extract a VBIOS from a bios update  
 Laptops with NVIDIA Optimus graphics often have the dGPU VBIOS integrated in their system BIOS, this makes extracting the VBIOS a complicated process. Provided you have a BIOS Update for your laptop, this tool might be able to automagically extract all available VBIOS from it.
 
+This version adds the ability to extract from HP Service Pack executable files. HP Service Packs contain embedded BIOS and VBIOS for HP laptops. Replacement graphics cards for HP laptops are usually shipped "bare" without any VBIOS installed.
+
 ## Dependencies
 - Ruby
 - bundler **(a ruby gem)**
@@ -31,6 +33,7 @@ Some dependencies might not offer a package for your linux distribution **(like
 - [ThinkPad T440p](https://github.com/coderobe/VBiosFinder/issues/21)
 - [ThinkPad T530](https://github.com/coderobe/VBiosFinder/issues/34)
 - [TravelMate P645-SG](https://github.com/coderobe/VBiosFinder/issues/9)
+- HP Service Packs
 
 - **note: if your device isn't listed here, feel free to try this tool and report your results!**
 

From 92f412822326c6a6b68aa3ef1e37c492142f161d Mon Sep 17 00:00:00 2001
From: RTHPJM <rthpjm@mac.com>
Date: Wed, 12 Apr 2023 10:17:57 +0100
Subject: [PATCH 3/5] Update extract-7z.rb

Fixed a typo
---
 src/extract-7z.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/extract-7z.rb b/src/extract-7z.rb
index bf1863e..1f626b8 100644
--- a/src/extract-7z.rb
+++ b/src/extract-7z.rb
@@ -28,7 +28,7 @@ def self.p7zip file
       rescue Terrapin::ExitStatusError => e
         result_Cab = false
       end
-      return result_Cab || result_7z
+      return result_Cab || result_7Z
     end
   end
 end

From cb8dab4e51b095ac246177d087e9865ffb9837ab Mon Sep 17 00:00:00 2001
From: RTHPJM <rthpjm@mac.com>
Date: Wed, 12 Apr 2023 10:26:59 +0100
Subject: [PATCH 4/5] Update README.md

Updated README
---
 README.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/README.md b/README.md
index 0b074c9..8188b12 100644
--- a/README.md
+++ b/README.md
@@ -20,6 +20,7 @@ Some dependencies might not offer a package for your linux distribution **(like
 ## Usage
 - Run `bundle install --path=vendor/bundle` to install the required ruby modules **(once)**
 - Run `./vbiosfinder extract /path/to/bios_update.exe` to attempt an extraction
+    - NOTE: /path/to/bios_update.exe **MUST** be a fully qualified path. Do **not** use relative path names
 - A temporary working dir is created at `./tmp-vbiosfinder` which can be removed inbetween runs
 - Extracted VBIOS roms will be placed in `./output`
 

From b9e16943403a7adac4a098a56ee9cb6fd27ad421 Mon Sep 17 00:00:00 2001
From: RTHPJM <rthpjm@mac.com>
Date: Wed, 12 Apr 2023 10:29:18 +0100
Subject: [PATCH 5/5] Update README.md

Another update to README
---
 README.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/README.md b/README.md
index 8188b12..5961d5e 100644
--- a/README.md
+++ b/README.md
@@ -21,6 +21,7 @@ Some dependencies might not offer a package for your linux distribution **(like
 - Run `bundle install --path=vendor/bundle` to install the required ruby modules **(once)**
 - Run `./vbiosfinder extract /path/to/bios_update.exe` to attempt an extraction
     - NOTE: /path/to/bios_update.exe **MUST** be a fully qualified path. Do **not** use relative path names
+    - NOTE: /path/to/bios_update.exe can be an HP Service Pack exe file, e.g. /home/user/sp012345.exe
 - A temporary working dir is created at `./tmp-vbiosfinder` which can be removed inbetween runs
 - Extracted VBIOS roms will be placed in `./output`