fix(lsp): refresh and relocate stale diagnostics

Author: fcoury-oai

Cargo.lock

@@ -82,6 +82,7 @@ json_comments = "0.2.2"
 lazy_static = "1.5.0"
 libloading = "0.8.9"
 nix = { version = "0.28.0", features = ["fs", "process", "signal"] }
+notify = "8.2.0"
 once_cell = "1.19.0"
 path-absolutize = "3.1.1"
 pulldown-cmark = "0.13"

Cargo.toml

@@ -12748,6 +12748,20 @@ impl Editor {
         self.update_diagnostics(uri, diagnostics, diagnostics::DiagnosticReportKind::Push)
     }
 
+    fn clear_current_buffer_diagnostics(&mut self) {
+        if self.diagnostics.is_empty() {
+            return;
+        }
+        let Ok(Some(uri)) = self.current_buffer().uri() else {
+            return;
+        };
+        if self.diagnostics.remove(&uri).is_none() {
+            return;
+        }
+        self.diagnostic_reports.remove(&uri);
+        self.sync_diagnostic_gutter_signs();
+    }
+
     fn update_diagnostics(
         &mut self,
         uri: Option<&str>,
@@ -23791,6 +23805,21 @@ impl Editor {
     }
 
     fn replace_range(&mut self, range: TextRange, new_text: &str) {
+        let diagnostic_edit = (!self.diagnostics.is_empty())
+            .then(|| self.current_buffer().uri().ok().flatten())
+            .flatten()
+            .and_then(|uri| {
+                self.diagnostics.contains_key(&uri).then(|| {
+                    let source = self.current_buffer();
+                    (
+                        uri,
+                        crate::lsp::Range {
+                            start: source.position_to_lsp(range.start),
+                            end: source.position_to_lsp(range.end),
+                        },
+                    )
+                })
+            });
         let pending =
             (self.config.lsp.enabled && self.current_buffer().file.is_some()).then(|| {
                 let source = self.current_buffer();
@@ -23819,6 +23848,12 @@ impl Editor {
                 new_text,
             );
         }
+        if let Some((uri, edit)) = diagnostic_edit {
+            if let Some(diagnostics) = self.diagnostic_reports.rebase(&uri, &edit, new_text) {
+                self.diagnostics.insert(uri, diagnostics);
+                self.sync_diagnostic_gutter_signs();
+            }
+        }
         perf::increment("edit:replacements", 1);
         self.update_anchors_for_edit(edit);
         self.set_special_mark_at_char('.', edit.start_char, AnchorAffinity::Left);
@@ -24358,6 +24393,7 @@ impl Editor {
             self.draw_commandline(render_buffer);
             return Ok(());
         };
+        self.clear_current_buffer_diagnostics();
         if let Some(transaction) = transaction {
             self.set_inline_history_transaction_applied(&transaction, false);
         }
@@ -24389,6 +24425,7 @@ impl Editor {
             self.draw_commandline(render_buffer);
             return Ok(());
         };
+        self.clear_current_buffer_diagnostics();
         if let Some(transaction) = self
             .current_buffer()
             .undo_history