Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor out helpers package #205

Open
rexim opened this issue May 9, 2017 · 1 comment
Open

Refactor out helpers package #205

rexim opened this issue May 9, 2017 · 1 comment
Labels
kind:refactoring

Comments

@rexim
Copy link
Member

rexim commented May 9, 2017 •
edited
Loading

Derived from #204 (comment)
@ForNeVeR
Copy link
Member

ForNeVeR commented May 9, 2017 •
edited by rexim
Loading

For the record (GitHub didn't properly show the linked comment), the comment text is:

"Helpers" and "Utilities" are instances of coincidental cohesion which is the worst possible cohesion according to Larry Constantine https://en.wikipedia.org/wiki/Cohesion_(computer_science)#Types_of_cohesion

I will create an issue to eliminate this package, but for I now I strongly recommend to create cors package and move everything related to CORS there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ForNeVeR @rexim