Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to support conditional arguments in generate-monitor due to variable auto-quoting #29

Open
adalessandro opened this issue Jan 15, 2025 · 0 comments

Comments

@adalessandro
Copy link

Related to https://gitlab.collabora.com/obs/ci-to-obs/-/merge_requests/26

The above MR aims to add support to conditionally download OBS results.
The idea is to have a CI variable/flag for this setting, then call generate-monitor with the proper parameters, adding/removing --download-build-results-to accordingly.

However, because of the limited syntax provided by the obs-runner, it doesn't seem to be possible at the moment.

From https://github.com/collabora/obs-gitlab-runner?tab=readme-ov-file#supported-syntax

There is no way to use a variable without auto-quoting its contents.

Calling generate-monitor with an empty quoted string will make it fail parsing arguments:

- >
  generate-monitor $OBS_RUNNER_TAG
    --artifact-expiration '3 days'
    ''

Calling generate-monitor with option --download-build-results-to '' will make it download results to the current directory.

Due to variable auto-quoting in the obs-runner, apparently there's no way to support this kind of variable based conditional arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant