Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null constraints to migration file? #572

Open
ramhoj opened this issue Mar 10, 2021 · 0 comments · May be fixed by #622
Open

Add null constraints to migration file? #572

ramhoj opened this issue Mar 10, 2021 · 0 comments · May be fixed by #622

Comments

@ramhoj
Copy link

ramhoj commented Mar 10, 2021

Is there a reason to why the auditable_id, auditable_type, action, audited_changes, version, request_uuid, and created_at fields are nullable? Are there cases where they are indeed created with null values or is it simply to be more flexible in upcoming changes without requiring the user to run a new schema migration?
jdufresne added a commit to jdufresne/audited that referenced this issue Apr 4, 2022
@jdufresne
Make several columns in the audits table NOT NULL
3d7f5d3 
Improve data integrity by adding NOT NULL constraints to columns that
should _always_ have a value. This helps catch application and library
bugs earlier by catching mishandling of data.

Fixes collectiveidea#572
@jdufresne jdufresne linked a pull request Apr 4, 2022 that will close this issue
Open
jdufresne added a commit to jdufresne/audited that referenced this issue Jan 29, 2023
@jdufresne
Make several columns in the audits table NOT NULL
865d559 
Improve data integrity by adding NOT NULL constraints to columns that
should _always_ have a value. This helps catch application and library
bugs earlier by catching mishandling of data.

Fixes collectiveidea#572
jdufresne added a commit to jdufresne/audited that referenced this issue Jan 29, 2023
@jdufresne
Make several columns in the audits table NOT NULL
7a36eb2 
Improve data integrity by adding NOT NULL constraints to columns that
should _always_ have a value. This helps catch application and library
bugs earlier by catching mishandling of data.

Fixes collectiveidea#572
jdufresne added a commit to jdufresne/audited that referenced this issue Jan 31, 2023
@jdufresne
Make several columns in the audits table NOT NULL
6ae1f83 
Improve data integrity by adding NOT NULL constraints to columns that
should _always_ have a value. This helps catch application and library
bugs earlier by catching mishandling of data.

Fixes collectiveidea#572
jdufresne added a commit to jdufresne/audited that referenced this issue Jan 31, 2023
@jdufresne
Make several columns in the audits table NOT NULL
de54e3b 
Improve data integrity by adding NOT NULL constraints to columns that
should _always_ have a value. This helps catch application and library
bugs earlier by catching mishandling of data.

Fixes collectiveidea#572
jdufresne added a commit to jdufresne/audited that referenced this issue Jan 31, 2023
@jdufresne
Make several columns in the audits table NOT NULL
d6f61d6 
Improve data integrity by adding NOT NULL constraints to columns that
should _always_ have a value. This helps catch application and library
bugs earlier by catching mishandling of data.

Fixes collectiveidea#572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make several columns in the audits table NOT NULL jdufresne/audited
1 participant
@ramhoj