Merge pull request #73 from jodersky/jo/space-cookie

Quote cookie values

Author: lihaoyi

requests/src/requests/Requester.scala

@@ -247,7 +247,7 @@ case class Requester(verb: String,
           connection.setRequestProperty(
             "Cookie",
             allCookies
-              .map{case (k, v) => k + "=" + v}
+              .map{case (k, v) => s"""$k="$v""""}
               .mkString("; ")
           )
         }

requests/test/src/requests/RequestTests.scala

@@ -110,6 +110,14 @@ object RequestTests extends TestSuite{
         val res2 = requests.get("https://httpbin.org/cookies").text().trim
         assert(read(res2) == Obj("cookies" -> Obj()))
       }
+      test("space"){
+        val s = requests.Session(cookieValues = Map("hello" -> "hello, world"))
+        val res1 = s.get("https://httpbin.org/cookies").text().trim
+        assert(read(res1) == Obj("cookies" -> Obj("hello" -> "hello, world")))
+        s.get("https://httpbin.org/cookies/set?freeform=test+test")
+        val res2 = s.get("https://httpbin.org/cookies").text().trim
+        assert(read(res2) == Obj("cookies" -> Obj("freeform" -> "test test", "hello" -> "hello, world")))
+      }
     }
     // Tests fail with 'Request to https://httpbin.org/absolute-redirect/4 failed with status code 404'
     // test("redirects"){