Skip to content

Commit 1015baa

Browse files
author
Douglas Blank
committed
Version 2.3.1: correctly copy remote assets
1 parent c80dea5 commit 1015baa

File tree

4 files changed

+23
-11
lines changed

4 files changed

+23
-11
lines changed

cometx/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@
1212
# the express permission of Comet ML Inc.
1313
# *******************************************************
1414

15-
version_info = (2, 3, 0)
15+
version_info = (2, 3, 1)
1616
__version__ = ".".join(map(str, version_info))

cometx/cli/copy.py

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -723,14 +723,26 @@ def log_assets(self, experiment, path, assets_metadata):
723723
for log_filename in assets_metadata:
724724
asset_type = assets_metadata[log_filename].get("type", "asset") or "asset"
725725
if asset_type not in ["confusion-matrix", "embeddings", "datagrid"]:
726-
self._log_asset(
727-
experiment,
728-
path,
729-
asset_type,
730-
log_filename,
731-
assets_metadata,
732-
asset_map,
733-
)
726+
if (
727+
"remote" in assets_metadata[log_filename]
728+
and assets_metadata[log_filename]["remote"]
729+
):
730+
asset = assets_metadata[log_filename]
731+
experiment.log_remote_asset(
732+
uri=asset["link"],
733+
remote_file_name=asset["fileName"],
734+
step=asset["step"],
735+
metadata=asset["metadata"],
736+
)
737+
else:
738+
self._log_asset(
739+
experiment,
740+
path,
741+
asset_type,
742+
log_filename,
743+
assets_metadata,
744+
asset_map,
745+
)
734746
# Process all nested assets:
735747
for log_filename in assets_metadata:
736748
asset_type = assets_metadata[log_filename].get("type", "asset") or "asset"

cometx/cli/copy_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import logging
1616
import shutil
1717

18-
from comet_ml.config_class import Config
18+
from comet_ml.config.config_class import Config
1919
from comet_ml.exceptions import (
2020
ExperimentAlreadyUploaded,
2121
ExperimentNotFound,

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def get_version(file, name="__version__"):
4646
long_description=long_description,
4747
long_description_content_type="text/markdown",
4848
install_requires=[
49-
"comet_ml",
49+
"comet_ml>=3.49.1",
5050
],
5151
extras_require={
5252
"all": [

0 commit comments

Comments
 (0)