Skip to content

Commit d192943

Browse files
ajimaeajimae
authored
[Chore] Fix Issues with Browser Example (#751)
* chore(browser.html): fix issues browser example - fix issues with browser example - replace webpack module bundle in favour of esbuild - minor refactor * chore(esbuild): remove unused variable - remove unused variable exec * chore(node-engine): ignore node engine ignore node engine check for now * chore(node-engine): ignore node engine ignore node engine check for now * chore(esbuild): fix typo errors - assign esbuild config to the correct variable name
1 parent f37e181 commit d192943

File tree

7 files changed

+191
-93
lines changed

7 files changed

+191
-93
lines changed

‎.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ jobs:
7575
- restore_cache: *restore_yarn_cache_node_16
7676
- run:
7777
name: Installing dependencies
78-
command: yarn install --frozen-lockfile
78+
command: yarn install --ignore-engines --frozen-lockfile # temp ignore engine checks [will deprecate node v16 soon]
7979
- save_cache: *save_yarn_cache_node_16
8080
- run:
8181
name: Install example dependencies

‎.nvmrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20.14.0
1+
20.15.0

‎esbuild.cjs

+31
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
const esbuild = require('esbuild');
2+
3+
const generalConfig = { minify: true, bundle: true, write: true }
4+
5+
const sdkClientConfig = esbuild.build(
6+
Object.assign({}, generalConfig, {
7+
entryPoints: ['packages/sdk-client/src/index.ts'],
8+
globalName: 'window["@commercetools/sdk-client-v2"]',
9+
outfile: 'packages/sdk-client/dist/commercetools-sdk-client-v2.umd.js'
10+
})
11+
)
12+
13+
const sdkClientV3Config = esbuild.build(
14+
Object.assign({}, generalConfig, {
15+
entryPoints: ['packages/sdk-client-v3/src/index.ts'],
16+
globalName: 'window["@commercetools/ts-client"]',
17+
outfile: 'packages/sdk-client-v3/dist/commercetools-ts-client.umd.js'
18+
})
19+
)
20+
21+
const platformSdkConfig = esbuild.build(
22+
Object.assign({}, generalConfig, {
23+
entryPoints: ['packages/platform-sdk/src/index.ts'],
24+
globalName: 'window["@commercetools/platform-sdk"]',
25+
outfile: 'packages/platform-sdk/dist/commercetools-platform-sdk.umd.js',
26+
})
27+
)
28+
29+
Promise.all([
30+
sdkClientConfig, sdkClientV3Config, platformSdkConfig
31+
]).catch(console.error);

‎examples/browser/browser.html

+6-4
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,12 @@
1414

1515

1616
<button id="btnDetails" onclick="getProjectDetails()">Get Project Details</button>
17-
<p id="details"></p>
17+
<pre>
18+
<p id="details"></p>
19+
</pre>
1820

1921
<script>
20-
(function() {
22+
function getProjectDetails() {
2123
var oauthUri = 'https://auth.europe-west1.gcp.commercetools.com'
2224
var baseUri = 'https://api.europe-west1.gcp.commercetools.com'
2325
var credentials = {
@@ -37,9 +39,9 @@
3739
.get()
3840
.execute()
3941
.then(function ({ body }) {
40-
window.document.getElementById('details').innerHTML = JSON.stringify(body);
42+
window.document.getElementById('details').innerHTML = JSON.stringify(body, null, 2);
4143
})
42-
}())
44+
}
4345
</script>
4446
</body>
4547

‎package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"changeset": "changeset",
1414
"test:unit": "yarn test --testPathIgnorePatterns='packages/platform-sdk/test/integration-tests'",
1515
"test:integration": "jest --testPathPattern='packages/platform-sdk/test/integration-tests'",
16-
"postbuild": "webpack --mode=production",
16+
"postbuild": "node esbuild.cjs",
1717
"changeset:version-and-format": "changeset version && prettier --write --parser json '**/package.json'",
1818
"docs": "rm -rf docs;typedoc"
1919
},
@@ -35,6 +35,7 @@
3535
"buffer": "^6.0.3",
3636
"clean-webpack-plugin": "^4.0.0",
3737
"codecov": "^3.2.5",
38+
"esbuild": "^0.23.0",
3839
"husky": "^8.0.0",
3940
"ignore-loader": "^0.1.2",
4041
"jest": "29.7.0",

‎webpack.config.js

-86
This file was deleted.

‎yarn.lock

+150
Original file line numberDiff line numberDiff line change
@@ -1700,6 +1700,126 @@
17001700
resolved "https://registry.npmjs.org/@discoveryjs/json-ext/-/json-ext-0.5.7.tgz"
17011701
integrity sha512-dBVuXR082gk3jsFp7Rd/JI4kytwGHecnCoTtXFb7DB6CNHp4rg5k1bhg0nWdLGLnOV71lmDzGQaLMy8iPLY0pw==
17021702

1703+
"@esbuild/[email protected]":
1704+
version "0.23.0"
1705+
resolved "https://registry.yarnpkg.com/@esbuild/aix-ppc64/-/aix-ppc64-0.23.0.tgz#145b74d5e4a5223489cabdc238d8dad902df5259"
1706+
integrity sha512-3sG8Zwa5fMcA9bgqB8AfWPQ+HFke6uD3h1s3RIwUNK8EG7a4buxvuFTs3j1IMs2NXAk9F30C/FF4vxRgQCcmoQ==
1707+
1708+
"@esbuild/[email protected]":
1709+
version "0.23.0"
1710+
resolved "https://registry.yarnpkg.com/@esbuild/android-arm64/-/android-arm64-0.23.0.tgz#453bbe079fc8d364d4c5545069e8260228559832"
1711+
integrity sha512-EuHFUYkAVfU4qBdyivULuu03FhJO4IJN9PGuABGrFy4vUuzk91P2d+npxHcFdpUnfYKy0PuV+n6bKIpHOB3prQ==
1712+
1713+
"@esbuild/[email protected]":
1714+
version "0.23.0"
1715+
resolved "https://registry.yarnpkg.com/@esbuild/android-arm/-/android-arm-0.23.0.tgz#26c806853aa4a4f7e683e519cd9d68e201ebcf99"
1716+
integrity sha512-+KuOHTKKyIKgEEqKbGTK8W7mPp+hKinbMBeEnNzjJGyFcWsfrXjSTNluJHCY1RqhxFurdD8uNXQDei7qDlR6+g==
1717+
1718+
"@esbuild/[email protected]":
1719+
version "0.23.0"
1720+
resolved "https://registry.yarnpkg.com/@esbuild/android-x64/-/android-x64-0.23.0.tgz#1e51af9a6ac1f7143769f7ee58df5b274ed202e6"
1721+
integrity sha512-WRrmKidLoKDl56LsbBMhzTTBxrsVwTKdNbKDalbEZr0tcsBgCLbEtoNthOW6PX942YiYq8HzEnb4yWQMLQuipQ==
1722+
1723+
"@esbuild/[email protected]":
1724+
version "0.23.0"
1725+
resolved "https://registry.yarnpkg.com/@esbuild/darwin-arm64/-/darwin-arm64-0.23.0.tgz#d996187a606c9534173ebd78c58098a44dd7ef9e"
1726+
integrity sha512-YLntie/IdS31H54Ogdn+v50NuoWF5BDkEUFpiOChVa9UnKpftgwzZRrI4J132ETIi+D8n6xh9IviFV3eXdxfow==
1727+
1728+
"@esbuild/[email protected]":
1729+
version "0.23.0"
1730+
resolved "https://registry.yarnpkg.com/@esbuild/darwin-x64/-/darwin-x64-0.23.0.tgz#30c8f28a7ef4e32fe46501434ebe6b0912e9e86c"
1731+
integrity sha512-IMQ6eme4AfznElesHUPDZ+teuGwoRmVuuixu7sv92ZkdQcPbsNHzutd+rAfaBKo8YK3IrBEi9SLLKWJdEvJniQ==
1732+
1733+
"@esbuild/[email protected]":
1734+
version "0.23.0"
1735+
resolved "https://registry.yarnpkg.com/@esbuild/freebsd-arm64/-/freebsd-arm64-0.23.0.tgz#30f4fcec8167c08a6e8af9fc14b66152232e7fb4"
1736+
integrity sha512-0muYWCng5vqaxobq6LB3YNtevDFSAZGlgtLoAc81PjUfiFz36n4KMpwhtAd4he8ToSI3TGyuhyx5xmiWNYZFyw==
1737+
1738+
"@esbuild/[email protected]":
1739+
version "0.23.0"
1740+
resolved "https://registry.yarnpkg.com/@esbuild/freebsd-x64/-/freebsd-x64-0.23.0.tgz#1003a6668fe1f5d4439e6813e5b09a92981bc79d"
1741+
integrity sha512-XKDVu8IsD0/q3foBzsXGt/KjD/yTKBCIwOHE1XwiXmrRwrX6Hbnd5Eqn/WvDekddK21tfszBSrE/WMaZh+1buQ==
1742+
1743+
"@esbuild/[email protected]":
1744+
version "0.23.0"
1745+
resolved "https://registry.yarnpkg.com/@esbuild/linux-arm64/-/linux-arm64-0.23.0.tgz#3b9a56abfb1410bb6c9138790f062587df3e6e3a"
1746+
integrity sha512-j1t5iG8jE7BhonbsEg5d9qOYcVZv/Rv6tghaXM/Ug9xahM0nX/H2gfu6X6z11QRTMT6+aywOMA8TDkhPo8aCGw==
1747+
1748+
"@esbuild/[email protected]":
1749+
version "0.23.0"
1750+
resolved "https://registry.yarnpkg.com/@esbuild/linux-arm/-/linux-arm-0.23.0.tgz#237a8548e3da2c48cd79ae339a588f03d1889aad"
1751+
integrity sha512-SEELSTEtOFu5LPykzA395Mc+54RMg1EUgXP+iw2SJ72+ooMwVsgfuwXo5Fn0wXNgWZsTVHwY2cg4Vi/bOD88qw==
1752+
1753+
"@esbuild/[email protected]":
1754+
version "0.23.0"
1755+
resolved "https://registry.yarnpkg.com/@esbuild/linux-ia32/-/linux-ia32-0.23.0.tgz#4269cd19cb2de5de03a7ccfc8855dde3d284a238"
1756+
integrity sha512-P7O5Tkh2NbgIm2R6x1zGJJsnacDzTFcRWZyTTMgFdVit6E98LTxO+v8LCCLWRvPrjdzXHx9FEOA8oAZPyApWUA==
1757+
1758+
"@esbuild/[email protected]":
1759+
version "0.23.0"
1760+
resolved "https://registry.yarnpkg.com/@esbuild/linux-loong64/-/linux-loong64-0.23.0.tgz#82b568f5658a52580827cc891cb69d2cb4f86280"
1761+
integrity sha512-InQwepswq6urikQiIC/kkx412fqUZudBO4SYKu0N+tGhXRWUqAx+Q+341tFV6QdBifpjYgUndV1hhMq3WeJi7A==
1762+
1763+
"@esbuild/[email protected]":
1764+
version "0.23.0"
1765+
resolved "https://registry.yarnpkg.com/@esbuild/linux-mips64el/-/linux-mips64el-0.23.0.tgz#9a57386c926262ae9861c929a6023ed9d43f73e5"
1766+
integrity sha512-J9rflLtqdYrxHv2FqXE2i1ELgNjT+JFURt/uDMoPQLcjWQA5wDKgQA4t/dTqGa88ZVECKaD0TctwsUfHbVoi4w==
1767+
1768+
"@esbuild/[email protected]":
1769+
version "0.23.0"
1770+
resolved "https://registry.yarnpkg.com/@esbuild/linux-ppc64/-/linux-ppc64-0.23.0.tgz#f3a79fd636ba0c82285d227eb20ed8e31b4444f6"
1771+
integrity sha512-cShCXtEOVc5GxU0fM+dsFD10qZ5UpcQ8AM22bYj0u/yaAykWnqXJDpd77ublcX6vdDsWLuweeuSNZk4yUxZwtw==
1772+
1773+
"@esbuild/[email protected]":
1774+
version "0.23.0"
1775+
resolved "https://registry.yarnpkg.com/@esbuild/linux-riscv64/-/linux-riscv64-0.23.0.tgz#f9d2ef8356ce6ce140f76029680558126b74c780"
1776+
integrity sha512-HEtaN7Y5UB4tZPeQmgz/UhzoEyYftbMXrBCUjINGjh3uil+rB/QzzpMshz3cNUxqXN7Vr93zzVtpIDL99t9aRw==
1777+
1778+
"@esbuild/[email protected]":
1779+
version "0.23.0"
1780+
resolved "https://registry.yarnpkg.com/@esbuild/linux-s390x/-/linux-s390x-0.23.0.tgz#45390f12e802201f38a0229e216a6aed4351dfe8"
1781+
integrity sha512-WDi3+NVAuyjg/Wxi+o5KPqRbZY0QhI9TjrEEm+8dmpY9Xir8+HE/HNx2JoLckhKbFopW0RdO2D72w8trZOV+Wg==
1782+
1783+
"@esbuild/[email protected]":
1784+
version "0.23.0"
1785+
resolved "https://registry.yarnpkg.com/@esbuild/linux-x64/-/linux-x64-0.23.0.tgz#c8409761996e3f6db29abcf9b05bee8d7d80e910"
1786+
integrity sha512-a3pMQhUEJkITgAw6e0bWA+F+vFtCciMjW/LPtoj99MhVt+Mfb6bbL9hu2wmTZgNd994qTAEw+U/r6k3qHWWaOQ==
1787+
1788+
"@esbuild/[email protected]":
1789+
version "0.23.0"
1790+
resolved "https://registry.yarnpkg.com/@esbuild/netbsd-x64/-/netbsd-x64-0.23.0.tgz#ba70db0114380d5f6cfb9003f1d378ce989cd65c"
1791+
integrity sha512-cRK+YDem7lFTs2Q5nEv/HHc4LnrfBCbH5+JHu6wm2eP+d8OZNoSMYgPZJq78vqQ9g+9+nMuIsAO7skzphRXHyw==
1792+
1793+
"@esbuild/[email protected]":
1794+
version "0.23.0"
1795+
resolved "https://registry.yarnpkg.com/@esbuild/openbsd-arm64/-/openbsd-arm64-0.23.0.tgz#72fc55f0b189f7a882e3cf23f332370d69dfd5db"
1796+
integrity sha512-suXjq53gERueVWu0OKxzWqk7NxiUWSUlrxoZK7usiF50C6ipColGR5qie2496iKGYNLhDZkPxBI3erbnYkU0rQ==
1797+
1798+
"@esbuild/[email protected]":
1799+
version "0.23.0"
1800+
resolved "https://registry.yarnpkg.com/@esbuild/openbsd-x64/-/openbsd-x64-0.23.0.tgz#b6ae7a0911c18fe30da3db1d6d17a497a550e5d8"
1801+
integrity sha512-6p3nHpby0DM/v15IFKMjAaayFhqnXV52aEmv1whZHX56pdkK+MEaLoQWj+H42ssFarP1PcomVhbsR4pkz09qBg==
1802+
1803+
"@esbuild/[email protected]":
1804+
version "0.23.0"
1805+
resolved "https://registry.yarnpkg.com/@esbuild/sunos-x64/-/sunos-x64-0.23.0.tgz#58f0d5e55b9b21a086bfafaa29f62a3eb3470ad8"
1806+
integrity sha512-BFelBGfrBwk6LVrmFzCq1u1dZbG4zy/Kp93w2+y83Q5UGYF1d8sCzeLI9NXjKyujjBBniQa8R8PzLFAUrSM9OA==
1807+
1808+
"@esbuild/[email protected]":
1809+
version "0.23.0"
1810+
resolved "https://registry.yarnpkg.com/@esbuild/win32-arm64/-/win32-arm64-0.23.0.tgz#b858b2432edfad62e945d5c7c9e5ddd0f528ca6d"
1811+
integrity sha512-lY6AC8p4Cnb7xYHuIxQ6iYPe6MfO2CC43XXKo9nBXDb35krYt7KGhQnOkRGar5psxYkircpCqfbNDB4uJbS2jQ==
1812+
1813+
"@esbuild/[email protected]":
1814+
version "0.23.0"
1815+
resolved "https://registry.yarnpkg.com/@esbuild/win32-ia32/-/win32-ia32-0.23.0.tgz#167ef6ca22a476c6c0c014a58b4f43ae4b80dec7"
1816+
integrity sha512-7L1bHlOTcO4ByvI7OXVI5pNN6HSu6pUQq9yodga8izeuB1KcT2UkHaH6118QJwopExPn0rMHIseCTx1CRo/uNA==
1817+
1818+
"@esbuild/[email protected]":
1819+
version "0.23.0"
1820+
resolved "https://registry.yarnpkg.com/@esbuild/win32-x64/-/win32-x64-0.23.0.tgz#db44a6a08520b5f25bbe409f34a59f2d4bcc7ced"
1821+
integrity sha512-Arm+WgUFLUATuoxCJcahGuk6Yj9Pzxd6l11Zb/2aAuv5kWWvvfhLFo2fni4uSK5vzlUdCGZ/BdV5tH8klj8p8g==
1822+
17031823
"@grpc/grpc-js@^1.7.1":
17041824
version "1.10.7"
17051825
resolved "https://registry.npmjs.org/@grpc/grpc-js/-/grpc-js-1.10.7.tgz"
@@ -4906,6 +5026,36 @@ es-to-primitive@^1.2.1:
49065026
is-date-object "^1.0.1"
49075027
is-symbol "^1.0.2"
49085028

5029+
esbuild@^0.23.0:
5030+
version "0.23.0"
5031+
resolved "https://registry.yarnpkg.com/esbuild/-/esbuild-0.23.0.tgz#de06002d48424d9fdb7eb52dbe8e95927f852599"
5032+
integrity sha512-1lvV17H2bMYda/WaFb2jLPeHU3zml2k4/yagNMG8Q/YtfMjCwEUZa2eXXMgZTVSL5q1n4H7sQ0X6CdJDqqeCFA==
5033+
optionalDependencies:
5034+
"@esbuild/aix-ppc64" "0.23.0"
5035+
"@esbuild/android-arm" "0.23.0"
5036+
"@esbuild/android-arm64" "0.23.0"
5037+
"@esbuild/android-x64" "0.23.0"
5038+
"@esbuild/darwin-arm64" "0.23.0"
5039+
"@esbuild/darwin-x64" "0.23.0"
5040+
"@esbuild/freebsd-arm64" "0.23.0"
5041+
"@esbuild/freebsd-x64" "0.23.0"
5042+
"@esbuild/linux-arm" "0.23.0"
5043+
"@esbuild/linux-arm64" "0.23.0"
5044+
"@esbuild/linux-ia32" "0.23.0"
5045+
"@esbuild/linux-loong64" "0.23.0"
5046+
"@esbuild/linux-mips64el" "0.23.0"
5047+
"@esbuild/linux-ppc64" "0.23.0"
5048+
"@esbuild/linux-riscv64" "0.23.0"
5049+
"@esbuild/linux-s390x" "0.23.0"
5050+
"@esbuild/linux-x64" "0.23.0"
5051+
"@esbuild/netbsd-x64" "0.23.0"
5052+
"@esbuild/openbsd-arm64" "0.23.0"
5053+
"@esbuild/openbsd-x64" "0.23.0"
5054+
"@esbuild/sunos-x64" "0.23.0"
5055+
"@esbuild/win32-arm64" "0.23.0"
5056+
"@esbuild/win32-ia32" "0.23.0"
5057+
"@esbuild/win32-x64" "0.23.0"
5058+
49095059
escalade@^3.1.1:
49105060
version "3.1.2"
49115061
resolved "https://registry.npmjs.org/escalade/-/escalade-3.1.2.tgz"

0 commit comments

Comments
 (0)