Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-default-0.8 obsoletes data-defaults-instance's #7545

Open
7 of 26 tasks
juhp opened this issue Oct 24, 2024 · 28 comments
Open
7 of 26 tasks

data-default-0.8 obsoletes data-defaults-instance's #7545

juhp opened this issue Oct 24, 2024 · 28 comments

Comments

@juhp
Copy link
Contributor

juhp commented Oct 24, 2024

data-default-0.8.0.0 is out of bounds for:

Note that this basically obsoletes data-default-instances-*

See below for the changelog

juhp added a commit that referenced this issue Oct 24, 2024
@byorgey
Copy link
Contributor

byorgey commented Oct 24, 2024

Does anyone know what the breaking changes are? There doesn't seem to be a changelog.

byorgey referenced this issue in mauke/data-default Oct 24, 2024
@tfausak
Copy link
Contributor

tfausak commented Oct 24, 2024

I can't find a change log either. Here's the diff: mauke/data-default@1e4f789...8178c67

@tarleb
Copy link
Contributor

tarleb commented Oct 24, 2024

I've opened an issue: mauke/data-default#28

@mauke
Copy link

mauke commented Oct 24, 2024

Changes in 0.8.0.0:

  • The split into multiple packages (data-default-class, data-default-instances-*) is gone. There is only data-default now (with no dependencies on data-default-class or anything).
  • data-default only depends on containers and base now (but requires base >= 4.8).
  • The Default instances for Data.DList and System.Locale are gone (but could be revived with updated versions of data-default-instances-dlist and data-default-instances-old-locale in the future?).
  • The Default instances for e -> a and IO a have been removed.
  • The "generic" default Default instance now supports sum types as well (by always choosing the left constructor).
  • The internal GDefault type is now semi-public (in the Data.Default.Internal module) and has stub documentation.
  • New instances:
    • Tuples of size up to 31 (previously 7)
    • Identity
    • Const
    • Proxy
    • Solo
    • Bool
    • CBool
    • Ptr
    • ConstPtr
    • FunPtr
    • IntPtr
    • WordPtr

@jgm
Copy link
Contributor

jgm commented Oct 24, 2024

The split into multiple packages (data-default-class, data-default-instances-*) is gone. There is only data-default now (with no dependencies on data-default-class or anything).

In that case, every package that depends on data-default-class or data-default-instances needs to be modified, right? So the above list is incomplete. I discovered this by trying to compile pandoc with the constraint data-default >= 0.8; it fails with an error building xml-conduit:

    • No instance for ‘Data.Default.Internal.Default X.ParseSettings’
        arising from a use of ‘def’

xml-conduit depends on data-default-class but not data-default.

@tfausak
Copy link
Contributor

tfausak commented Oct 24, 2024

Yes, I ran into the same issue.

@tek
Copy link
Contributor

tek commented Oct 24, 2024

published a revision of incipit-base

@juhp
Copy link
Contributor Author

juhp commented Oct 25, 2024

The split into multiple packages (data-default-class, data-default-instances-*) is gone. There is only data-default now (with no dependencies on data-default-class or anything).

In that case, every package that depends on data-default-class or data-default-instances needs to be modified, right? So the above list is incomplete. I discovered this by trying to compile pandoc with the constraint data-default >= 0.8; it fails with an error building xml-conduit

Ah I see - feels like this needs wider awareness, a Discourse post/announcement would probably make sense?
But okay I guess we could try to generate a list of dependents (I suppose data-default-class should be sufficient):

@Minoru
Copy link
Contributor

Minoru commented Oct 25, 2024

/cc @LaurentRDC . NB: Hakyll will have to wait until pandoc is updated.

9999years added a commit to MercuryTechnologies/push-notify-apn that referenced this issue Oct 25, 2024
- In http2, `HeaderList` was replaced with `[Header]`,
  `SettingsHeaderTableSize` was replaced with
  `SettingsTokenHeaderTableSize`.

- data-default 0.8 deprecates data-default-class by moving the `Default`
  class from `Data.Default.Class` to `Data.Default`.

- tls has replaced some default instances with functions and made some
  record constructors private.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
@Minoru
Copy link
Contributor

Minoru commented Oct 25, 2024

Fixed for hakyll-convert by revision 0.3.0.5@rev:2.

9999years added a commit to MercuryTechnologies/push-notify-apn that referenced this issue Oct 25, 2024
- In http2, `HeaderList` was replaced with `[Header]`,
  `SettingsHeaderTableSize` was replaced with
  `SettingsTokenHeaderTableSize`.

- data-default 0.8 deprecates data-default-class by moving the `Default`
  class from `Data.Default.Class` to `Data.Default`.

- tls has replaced some default instances with functions and made some
  record constructors private.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
@jgm
Copy link
Contributor

jgm commented Oct 25, 2024

At the very least xml-conduit should be added to the list above and its maintainer notified. Pandoc won't build with data-default 0.8 without changes there. Perhaps there are other packages, too, that depend on data-default-class but not data-default.

9999years added a commit to 9999years/hs-connection that referenced this issue Oct 25, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

This is used upstream in `tls`.

See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
@byorgey
Copy link
Contributor

byorgey commented Oct 25, 2024

Perhaps there are other packages, too, that depend on data-default-class but not data-default.

@jgm see @juhp 's above comment with a link to a list of such packages. I agree perhaps we should add those packages to the list in this issue as well.

9999years added a commit to 9999years/http-client that referenced this issue Oct 25, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
@juhp juhp changed the title data-default-0.8 data-default-0.8 obsoletes data-default-class and data-defaults-instance's Oct 26, 2024
@juhp

This comment was marked as outdated.

@danielrolls
Copy link
Contributor

Fixed in shellify-0.11.0.5

@juhp
Copy link
Contributor Author

juhp commented Oct 27, 2024

Okay so actually data-default-class 0.2.0 was released for backward compatibility now.

@juhp juhp changed the title data-default-0.8 obsoletes data-default-class and data-defaults-instance's data-default-0.8 obsoletes data-defaults-instance's Oct 27, 2024
9999years added a commit to 9999years/quic that referenced this issue Oct 28, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
9999years added a commit to 9999years/wai that referenced this issue Oct 28, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
9999years added a commit to 9999years/wai that referenced this issue Oct 28, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
9999years added a commit to 9999years/wai that referenced this issue Oct 28, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
9999years added a commit to 9999years/xml that referenced this issue Oct 28, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: commercialhaskell/stackage#7545
alaendle added a commit that referenced this issue Oct 30, 2024
@debug-ito
Copy link
Contributor

I released fold-debounce-0.2.0.13. I switched to data-default.

k0ral pushed a commit to snoyberg/xml that referenced this issue Oct 31, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: commercialhaskell/stackage#7545
@adetokunbo
Copy link
Contributor

I released wai-middleware-delegate-0.2.0.0
The library no longer uses data-default, and the test-suite upper-bound allows data-default-0.8

@adetokunbo
Copy link
Contributor

I released https://hackage.haskell.org/package/tmp-proc-0.7.2.0 which relaxes the upper-bound to allow data-default-0.8

mihaimaruseac added a commit that referenced this issue Nov 6, 2024
Signed-off-by: Mihai Maruseac <[email protected]>
mihaimaruseac added a commit that referenced this issue Nov 6, 2024
Signed-off-by: Mihai Maruseac <[email protected]>
@mihaimaruseac
Copy link
Contributor

Current status:

data-default-0.8.0.0 (changelog) (Grandfathered dependencies) is out of bounds for:

data-default-class-0.2.0.0 (changelog) (Grandfathered dependencies) is out of bounds for:

To which we also need to add

tls-2.1.1 (changelog) (Kazu Yamamoto [email protected] @kazu-yamamoto, Stackage upper bounds) is out of bounds for:

(meaning I'll add an upper bound on warp-tls until this gets closed)

mihaimaruseac added a commit that referenced this issue Nov 6, 2024
Signed-off-by: Mihai Maruseac <[email protected]>
mihaimaruseac added a commit that referenced this issue Nov 7, 2024
Signed-off-by: Mihai Maruseac <[email protected]>
thomasjm added a commit to haskell-webdriver/haskell-webdriver that referenced this issue Nov 8, 2024
@thomasjm
Copy link
Contributor

thomasjm commented Nov 8, 2024

Uploaded webdriver-0.12.0.1 which just replaces the data-default-class dependency with data-default.

@robstewart57
Copy link
Contributor

Done for gitlab-haskell:

https://gitlab.com/robstewart57/gitlab-haskell/-/commit/82dac90b1b399f54eceb5a36961479042ff19800

Please let me know if there's anything additional to be done.

@MichaelXavier
Copy link
Contributor

Uploaded cron-0.7.2 which replaces data-default-class with data-default.

mihaimaruseac added a commit to commercialhaskell/lts-haskell that referenced this issue Nov 10, 2024
```
tls-1.8.0 ([changelog](http://hackage.haskell.org/package/tls-1.8.0/changelog)) (Stackage upper bounds, Vincent Hanquez @vincenthz) is out of bounds for:
- [ ] warp-tls-3.4.11 (>=2.1.3 && < 2.2). Michael Snoyman [email protected] @snoyberg. Used by: library
```

Also, commercialhaskell/stackage#7545

Signed-off-by: Mihai Maruseac <[email protected]>
@LaurentRDC
Copy link
Contributor

Revised hakyll-4.16.3.0 to support data-default-0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests