fix: mypy

Author: Stellatsuu

cwltool/checker.py

@@ -559,14 +559,14 @@ def loop_checker(steps: Iterator[MutableMapping[str, Any]]) -> None:
         raise ValidationException("\n".join(exceptions))
 
 
-def resreq_minmax_checker(requirement: CWLObjectType):
+def resreq_minmax_checker(requirement: CWLObjectType) -> None:
     """
     Check if the minResource is lesser than the maxResource in resource requirements.
 
     :raises ValidationException: If the minResource is greater than the maxResource.
     """
     for a in ("cores", "ram", "tmpdir", "outdir"):
-        mn: int | float | None = requirement.get(a + "Min")
-        mx: int | float | None = requirement.get(a + "Max")
+        mn: int | float | None = cast(Union[int, float], requirement.get(a + "Min"))
+        mx: int | float | None = cast(Union[int, float], requirement.get(a + "Max"))
         if mn is not None and mx is not None and mx < mn:
             raise ValidationException(f"{a}Min cannot be greater than {a}Max.")

cwltool/process.py

@@ -1027,11 +1027,11 @@ def evalResources(
             elif mx is None:
                 mx = mn
 
-            if mn is not None:
+            if mn is not None and mx is not None:
                 if mx < mn:
                     raise ValidationException(f"{a}Min cannot be greater than {a}Max.")
                 request[a + "Min"] = mn
-                request[a + "Max"] = cast(Union[int, float], mx)
+                request[a + "Max"] = mx
 
         request_evaluated = cast(dict[str, Union[int, float]], request)
         if runtimeContext.select_resources is not None:

tests/test_examples.py

@@ -1846,7 +1846,7 @@ def test_make_template() -> None:
 @pytest.mark.parametrize(
     "file", ["tests/wf/bad_resreq_mnmx_clt.cwl", "tests/wf/bad_resreq_mnmx_wf.cwl"]
 )
-def test_invalid_resource_requirements(file):
+def test_invalid_resource_requirements(file: str) -> None:
     """Ensure an error with an invalid resource requirement."""
     exit_code, stdout, stderr = get_main_output(
         [

tests/test_validate.py

@@ -3,6 +3,7 @@
 import io
 import logging
 import re
+
 import pytest
 
 from .util import get_data, get_main_output
@@ -131,7 +132,7 @@ def test_validate_custom_logger() -> None:
 @pytest.mark.parametrize(
     "file", ["tests/wf/bad_resreq_mnmx_clt.cwl", "tests/wf/bad_resreq_mnmx_wf.cwl"]
 )
-def test_validate_with_invalid_requirements(file) -> None:
+def test_validate_with_invalid_requirements(file: str) -> None:
     """Ensure that --validate returns an error with an invalid resource requirement."""
     exit_code, stdout, stderr = get_main_output(
         [