Nearby upload often fails ("Failed", "closed")

[nicolas-raoul]

I perform many uploads, of which around 10% is via Nearby.

There are often failures when I ride the elevator, but automatic retries work great... except for Nearby pictures.

The pictures that stay stuck in the "Failed" tab are always ones I uploaded via Nearby.

In the screenshot above, the first and third have actually been uploaded but just not linked from Wikidata. The second has not been uploaded at all.

[nicolas-raoul]

Today one (out of 5) of my Nearby images is stuck in Pending with a subtitle closed.
I checked the Wikimedia Commons server: the image has not been uploaded.
Here is adb logcat when I retry it and it crashes:

06-29 20:03:22.109 29687 29687 D AndroidRuntime: Shutting down VM
06-29 20:03:22.110 29687 29687 E AndroidRuntime: FATAL EXCEPTION: main
06-29 20:03:22.110 29687 29687 E AndroidRuntime: Process: fr.free.nrw.commons, PID: 29687
06-29 20:03:22.110 29687 29687 E AndroidRuntime: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:603)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:929)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: Caused by: java.lang.reflect.InvocationTargetException
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:593)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	... 1 more
06-29 20:03:22.110 29687 29687 E AndroidRuntime: Caused by: java.io.FileNotFoundException: /data/user/0/fr.free.nrw.commons/cache/CommonsContributions/f2d92a45-c131-41c8-bddc-0dba702a4138.jpg: open failed: ENOENT (No such file or directory)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at libcore.io.IoBridge.open(IoBridge.java:574)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at java.io.FileInputStream.<init>(FileInputStream.java:179)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at java.io.FileInputStream.<init>(FileInputStream.java:133)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at fr.free.nrw.commons.upload.FileUtils.getFileInputStream(FileUtils.kt:150)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at fr.free.nrw.commons.upload.FileUtilsWrapper.getFileInputStream(FileUtilsWrapper.kt:25)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at fr.free.nrw.commons.upload.ImageProcessingService.checkIfFileAlreadyExists(ImageProcessingService.kt:133)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at fr.free.nrw.commons.upload.UploadModel.checkDuplicateImage(UploadModel.kt:108)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at fr.free.nrw.commons.repository.UploadRepository.checkDuplicateImage(UploadRepository.kt:209)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at fr.free.nrw.commons.upload.PendingUploadsPresenter.restartUpload(PendingUploadsPresenter.kt:227)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at fr.free.nrw.commons.upload.FailedUploadsFragment.restartUpload(FailedUploadsFragment.kt:139)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at fr.free.nrw.commons.upload.FailedUploadsAdapter.onBindViewHolder$lambda$2(FailedUploadsAdapter.kt:110)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at fr.free.nrw.commons.upload.FailedUploadsAdapter.$r8$lambda$_gSn6a3CmLqnJPpRbL2tSaT393E(Unknown Source:0)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at fr.free.nrw.commons.upload.FailedUploadsAdapter$$ExternalSyntheticLambda3.onClick(D8$$SyntheticClass:0)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at android.view.View.performClick(View.java:8228)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at android.view.View.performClickInternal(View.java:8205)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at android.view.View$PerformClick.run(View.java:31785)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:1041)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:103)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at android.os.Looper.dispatchMessage(Looper.java:315)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:251)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:349)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:9041)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	... 3 more
06-29 20:03:22.110 29687 29687 E AndroidRuntime: Caused by: android.system.ErrnoException: open failed: ENOENT (No such file or directory)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at libcore.io.Linux.open(Native Method)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at libcore.io.ForwardingOs.open(ForwardingOs.java:568)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at libcore.io.BlockGuardOs.open(BlockGuardOs.java:274)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at libcore.io.ForwardingOs.open(ForwardingOs.java:568)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at android.app.AndroidForwardingOs.open(AndroidForwardingOs.java:120)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	at libcore.io.IoBridge.open(IoBridge.java:560)
06-29 20:03:22.110 29687 29687 E AndroidRuntime: 	... 25 more
06-29 20:03:22.114 29687 29687 E ACRA    : ACRA caught a RuntimeException for fr.free.nrw.commons
06-29 20:03:22.114 29687 29687 E ACRA    : java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
06-29 20:03:22.114 29687 29687 E ACRA    : 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:603)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:929)
06-29 20:03:22.114 29687 29687 E ACRA    : Caused by: java.lang.reflect.InvocationTargetException
06-29 20:03:22.114 29687 29687 E ACRA    : 	at java.lang.reflect.Method.invoke(Native Method)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:593)
06-29 20:03:22.114 29687 29687 E ACRA    : 	... 1 more
06-29 20:03:22.114 29687 29687 E ACRA    : Caused by: java.io.FileNotFoundException: /data/user/0/fr.free.nrw.commons/cache/CommonsContributions/f2d92a45-c131-41c8-bddc-0dba702a4138.jpg: open failed: ENOENT (No such file or directory)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at libcore.io.IoBridge.open(IoBridge.java:574)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at java.io.FileInputStream.<init>(FileInputStream.java:179)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at java.io.FileInputStream.<init>(FileInputStream.java:133)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at fr.free.nrw.commons.upload.FileUtils.getFileInputStream(FileUtils.kt:150)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at fr.free.nrw.commons.upload.FileUtilsWrapper.getFileInputStream(FileUtilsWrapper.kt:25)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at fr.free.nrw.commons.upload.ImageProcessingService.checkIfFileAlreadyExists(ImageProcessingService.kt:133)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at fr.free.nrw.commons.upload.UploadModel.checkDuplicateImage(UploadModel.kt:108)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at fr.free.nrw.commons.repository.UploadRepository.checkDuplicateImage(UploadRepository.kt:209)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at fr.free.nrw.commons.upload.PendingUploadsPresenter.restartUpload(PendingUploadsPresenter.kt:227)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at fr.free.nrw.commons.upload.FailedUploadsFragment.restartUpload(FailedUploadsFragment.kt:139)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at fr.free.nrw.commons.upload.FailedUploadsAdapter.onBindViewHolder$lambda$2(FailedUploadsAdapter.kt:110)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at fr.free.nrw.commons.upload.FailedUploadsAdapter.$r8$lambda$_gSn6a3CmLqnJPpRbL2tSaT393E(Unknown Source:0)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at fr.free.nrw.commons.upload.FailedUploadsAdapter$$ExternalSyntheticLambda3.onClick(D8$$SyntheticClass:0)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at android.view.View.performClick(View.java:8228)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at android.view.View.performClickInternal(View.java:8205)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at android.view.View$PerformClick.run(View.java:31785)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at android.os.Handler.handleCallback(Handler.java:1041)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at android.os.Handler.dispatchMessage(Handler.java:103)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at android.os.Looper.dispatchMessage(Looper.java:315)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at android.os.Looper.loopOnce(Looper.java:251)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at android.os.Looper.loop(Looper.java:349)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at android.app.ActivityThread.main(ActivityThread.java:9041)
06-29 20:03:22.114 29687 29687 E ACRA    : 	... 3 more
06-29 20:03:22.114 29687 29687 E ACRA    : Caused by: android.system.ErrnoException: open failed: ENOENT (No such file or directory)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at libcore.io.Linux.open(Native Method)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at libcore.io.ForwardingOs.open(ForwardingOs.java:568)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at libcore.io.BlockGuardOs.open(BlockGuardOs.java:274)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at libcore.io.ForwardingOs.open(ForwardingOs.java:568)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at android.app.AndroidForwardingOs.open(AndroidForwardingOs.java:120)
06-29 20:03:22.114 29687 29687 E ACRA    : 	at libcore.io.IoBridge.open(IoBridge.java:560)
06-29 20:03:22.114 29687 29687 E ACRA    : 	... 25 more
06-29 20:03:22.169 29687 29687 I Process : Sending signal. PID: 29687 SIG: 9
06-29 20:03:22.252 27977 27977 I Zygote  : Process 29687 exited due to signal 9 (Killed)

[RitikaPahwa4444]

data/user/0/fr.free.nrw.commons/cache/CommonsContributions/f2d92a45-c131-41c8-bddc-0dba702a4138.jpg

Is this for 100% failure (second image) or partial failure? To avoid duplicates, we'd added a condition last year to check if the image exists already on the server. If we're cleaning up our tmp files in the middle of the process (upload complete but wikidata update pending), we would end up with this error. I've not checked the code yet but this crash has increased a lot, so I would suggest checking this once.

[nicolas-raoul]

@RitikaPahwa4444 I updated my description above, please let me know if anything is still unclear. :-)

[nicolas-raoul]

Potential investigation technique: To reproduce the issue, it might help to temporarily add a 10 seconds wait between upload and setting P18, and manually cut the internet during that wait?