java.lang.NullPointerException in ReviewActivity

[RitikaPahwa4444]

STACK_TRACE=java.lang.NullPointerException: Attempt to invoke virtual method 'android.graphics.Rect android.graphics.drawable.Drawable.getBounds()' on a null object reference
at fr.free.nrw.commons.review.ReviewActivity.onCreate$lambda$3(ReviewActivity.kt:112)
at fr.free.nrw.commons.review.ReviewActivity.$r8$lambda$qSRwW3DTTT07qwl8faDjZpuvgkA(ReviewActivity.kt:0)
at fr.free.nrw.commons.review.ReviewActivity$$ExternalSyntheticLambda2.onTouch(R8$$SyntheticClass:0)
at android.view.View.dispatchTouchEvent(View.java:14514)
at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3186)
at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2831)
at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3186)
at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2831)
at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3186)
at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2831)
at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3186)
at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2831)
at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3186)
at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2831)
at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3186)
at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2831)
at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3186)
at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2831)
at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:575)
at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1889)
at android.app.Activity.dispatchTouchEvent(Activity.java:4211)
at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:70)
at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:525)
at android.view.View.dispatchPointerEvent(View.java:14786)
at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:6760)
at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6526)
at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5951)
at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6015)
at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5974)
at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:6160)
at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5982)
at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:6217)
at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5955)
at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6015)
at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5974)
at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5982)
at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5955)
at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:8958)
at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:8909)
at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:8860)
at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:9101)
at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:220)
at android.os.MessageQueue.nativePollOnce(Native Method)
at android.os.MessageQueue.next(MessageQueue.java:339)
at android.os.Looper.loop(Looper.java:199)
at android.app.ActivityThread.main(ActivityThread.java:8212)
at java.lang.reflect.Method.invoke(Native Method)

at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:632)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1049)

IS_SILENT=false

This was reported in v5.6.0-beta. This is a crash report submitted by a user without detailed steps to reproduce, so an additional task would be to figure out when this crash happens.

[Jason-Whitmore]

I am able to reproduce this:

1. Change the app's language to a language which reads from right to left (e.g. Arabic).
2. Go to the review screen (If you are like me and can't read Arabic, go to the sandwich menu and select the option with the checkmark). Notice how the information icon is on the left of the "Skip Review" button:

In languages that are read left to right (like English), this icon is on the right side
3. Tap the information icon. The app will then crash.

In activity_review.xml the information icon is placed using android:drawableEnd="@drawable/ic_info_outline_24dp", rather than android:drawableRight. This allows icons to be placed at the end of the sentence for all languages, rather than placing the icon on the right side which would be correct for some users (like English speakers), but incorrect for other users (like Arabic speakers).

The crash happens because the code in ReviewActivity.kt:112 assumes that the icon is always on the right side of the text and therefore tries to access the right side Drawable with binding.skipImage.compoundDrawables[2] (2 being the index for the right side Drawable). In languages read right to left, the object at that index is null and instead the object at the left side Drawable index is populated. Calling a method on the null Drawable causes the NPE.

I would like to be assigned this issue. I assume we should keep the information icon placement where it is currently (depends on user language), and simply change the Kotlin code to not assume the placement with a fixed index.

[RitikaPahwa4444]

Thanks @Jason-Whitmore for such detailed analysis! :)