omv: bumps default os to v13 (trixie) + network fix + omv-extras installation step#13690
omv: bumps default os to v13 (trixie) + network fix + omv-extras installation step#13690pedro-pereira-dev wants to merge 1 commit into
Conversation
github-actions
Bot
added
bugfix
feature
refactor
update script
pedro-pereira-dev
force-pushed
the
omv-update
branch
from
1fc2da9 to
f876cb6
Compare
| if whiptail \ | ||
| --title "Customize OMV" \ | ||
| --yesno "Would you like to add OMV-extras, plugins repository for OMV?\n(https://wiki.omv-extras.org/)" \ | ||
| --defaultno \ | ||
| 8 60; then | ||
| msg_info "Installing OMV extras" | ||
| $STD bash <(curl -fsSL https://github.com/OpenMediaVault-Plugin-Developers/packages/raw/master/install) | ||
| msg_ok "Installed OMV extras" | ||
| fi |
There was a problem hiding this comment.
whats that? Why if whiptail? why an bash?
There was a problem hiding this comment.
OMV-extras is a convenient way to add functionality to an OMV installation.
The reasoning behind add it as an installation step was purely for the users convenience, defaulting to skip the installation. If no value is seen in this I am completely fine about removing this block.
In regards to whiptail, that is the guidance in this documentation, please let me know otherwise.
why an bash?
Not sure I understand what you meant by this, can you please elaborate?
Thank you for the review!
There was a problem hiding this comment.
Removed whiptail now
Please let me know if you would like this in any other way or for me to remove this last step
There was a problem hiding this comment.
@pedro-pereira-dev @MickLesk asked you why are you doing a bash call there when entire install is installing one .deb from their repo: https://github.com/OpenMediaVault-Plugin-Developers/packages/blob/master/openmediavault-omvextrasorg_latest_all8.deb
You should replace that bash call with:
fetch_and_deploy_from_url "https://github.com/OpenMediaVault-Plugin-Developers/packages/raw/refs/heads/master/openmediavault-omvextrasorg_latest_all8.deb"
pedro-pereira-dev
force-pushed
the
omv-update
branch
from
703e957 to
bb6056e
Compare
pedro-pereira-dev
force-pushed
the
omv-update
branch
2 times, most recently
from
29af3f4 to
e39b257
Compare
pedro-pereira-dev
force-pushed
the
omv-update
branch
from
e39b257 to
d75cfbd
Compare
|
Wouldn´t that not be better suites as a addon? Like we have in the addon folder. you might want to check it out. What do the other @community-scripts/contributor think? |
|
I think as it's deeply built into omv I think it majes more sense to ditectly include it in omv installation and ask the user about it with a whiptail/read prompt, as I don't think writing a whole addon script for this is worth it, also consider (afaik)you only need to run it once to activate the repos and not like update it. |
|
|
||
| export LANG=C.UTF-8 | ||
| export DEBIAN_FRONTEND=noninteractive | ||
| echo "deb [signed-by=/etc/apt/trusted.gpg.d/openmediavault-archive-keyring.gpg] http://packages.openmediavault.org/public synchrony main" >/etc/apt/sources.list.d/openmediavault.list |
There was a problem hiding this comment.
Can you directly use our setup_deb822 func?
|
@pedro-pereira-dev This PR has been marked as stale. It will be closed if no new commits are added in 7 days. |
5 participants
✍️ Description
Creating a new PR following #13644 .
Changes done:
trixieTests done:
bookwormversion of the containertrixieversion of the containerI appreaciate your feedback and thanks :)
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.