Skip to content

ISponsorblockTV: detect CPU capabilities to select compatible binary#14677

Open
MickLesk wants to merge 1 commit into
mainfrom
fix/isponsorblocktv-cpu-compat
Open

ISponsorblockTV: detect CPU capabilities to select compatible binary#14677
MickLesk wants to merge 1 commit into
mainfrom
fix/isponsorblocktv-cpu-compat

Conversation

@MickLesk
Copy link
Copy Markdown
Member

✍️ Description

  • iSponsorBlockTV-x86_64-linux → modern CPUs (AVX/AVX2/MOVBE)
  • iSponsorBlockTV-x86_64-linux-v1 → any x86_64 CPU (fallback)

🔗 Related Issue

Fixes #14660

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to script metadata (PocketBase/website data).
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

…nary

Instead of hard-failing when AVX is not present, detect whether the host
CPU supports AVX + AVX2 + MOVBE (x86-64-v3 microarchitecture level) and
select the appropriate upstream binary accordingly:

- iSponsorBlockTV-x86_64-linux     → modern CPUs (AVX/AVX2/MOVBE)
- iSponsorBlockTV-x86_64-linux-v1  → any x86_64 CPU (fallback)

The same detection logic is applied in update_script() so updates
stay consistent with the initially installed binary type.

Fixes: #14660
Upstream: dmunozv04/iSponsorBlockTV#463
@MickLesk MickLesk requested a review from a team as a code owner May 23, 2026 20:51
@github-actions github-actions Bot added feature update script A change that updates a script labels May 23, 2026
@braveheart777
Copy link
Copy Markdown

Thanks for pushing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iSponsorBlockTV setup fails. Python interpreter error. Not the same as Issue #13191. My CPU does support AVX instructions.

3 participants