zziplib: Add version 0.13.18 #25876
zziplib: Add version 0.13.18 #25876
Conversation
|
Hook warnings galore! :P |
|
Is the outstanding hook warning correct? |
Nope. It was not able to deal with that library name: https://github.com/conan-io/conan-center-index/pull/25876/checks?check_run_id=32671715312 The addressed hook information can be found here: https://c3i.jfrog.io/artifactory/cci-build-logs/cci/prod/PR-25876/3/package_build_logs/hook_output_zziplib_0_13_78_a702ebdfc849d51f40651cfd8010aecb_4b22fa0f2e3c3bf57410774c934fd2c53ffc357f.json
The same points to the build log https://c3i.jfrog.io/artifactory/cci-build-logs/cci/prod/PR-25876/3/package_build_logs/build_log_zziplib_0_13_78_a702ebdfc849d51f40651cfd8010aecb_4b22fa0f2e3c3bf57410774c934fd2c53ffc357f.success.txt, which proves the opposite:
|
Signed-off-by: Uilian Ries <[email protected]>
|
Windows error is a missing DLL |
|
@jcar87 The hook |
| # Old versions do not support llvm >= 15 | ||
| if (Version(self.version) < "0.13.78" | ||
| and self.settings.compiler in ("clang", "apple-clang") | ||
| and Version(self.settings.compiler.version) >= "15.0"): |
There was a problem hiding this comment.
mm apple clang and clang follow different versioning schemes, even if they seem similar - apple clang 15.0 is actually based on llvm 16 - and if the failure is bsed on llvm >-1 there are certain versions of apple-clang 14 that also fall in that category - do we know which one it is?
| if (Version(self.version) < "0.13.78" | ||
| and self.settings.compiler in ("clang", "apple-clang") | ||
| and Version(self.settings.compiler.version) >= "15.0"): | ||
| raise ConanInvalidConfiguration(f"{self.ref} does not support {self.settings.compiler} >= 15 due to incompatible pointer to integer conversion errors") |
There was a problem hiding this comment.
I think we can leave the {self.ref} out? if I remember correctly it is reported by conan before printing it, and any programmatic access is tied to the very reference, so it is redundant?
Closes #25705