[package] mpdecimal/2.5.1: Extra dependency on automake for MSVC builds

[StingX84]

Description

The package sets dependence on "Autoconf" and "Msys2" for MSVC, although only NMAKE is used during build.

The function that determines the dependence at the current moment:

    def build_requirements(self):
        if is_msvc(self):
            self.tool_requires("automake/1.16.5")
        else:
            # required to support windows as a build machine
            if self._settings_build.os == "Windows":
                self.win_bash = True
                if not self.conf.get("tools.microsoft.bash:path", check_type=str):
                    self.tool_requires("msys2/cci.latest")

But can be perfectly simplified to:

    def build_requirements(self):
        # required to support windows as a build machine
        if not is_msvc(self) and self._settings_build.os == "Windows":
            self.win_bash = True
            if not self.conf.get("tools.microsoft.bash:path", check_type=str):
                self.tool_requires("msys2/cci.latest")

With this configuration, everything builds without any problem and extra large dependencies.

Package and Environment Details

• Package Name/Version: mpdecimal/2.5.1
• Operating System+version: Windows 11
• Compiler+version: Visual Studio 2022
• Conan version: conan 1.65.0
• Python version: Python 3.9.13

Conan profile

[settings]
os=Windows
os_build=Windows
arch=x86_64
arch_build=x86_64
compiler=Visual Studio
compiler.runtime=MDd
compiler.version=17
compiler.toolset=v143
build_type=Debug
[options]
[build_requires]
[env]

Steps to reproduce

conan info -b * mpdecimal/2.5.1@

Logs

Click to expand log

mpdecimal/2.5.1: Forced build from source
m4/1.4.19: Forced build from source
autoconf/2.72: Forced build from source
automake/1.16.5: Forced build from source
msys2/cci.latest: Forced build from source
msys2/cci.latest, m4/1.4.19, autoconf/2.72, automake/1.16.5, mpdecimal/2.5.1

[Ahajha]

Note that Conan 1 recipes are frozen now - so unless you're pulling changes locally you won't see any changes to it.

I have a few mpdecimal PRs out right now, one of them will fix this.