gdal: Fix 3.7.3 and 3.8.3 builds by replacing Parquet and ArrowDataset version variables with Arrow one #25898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderCRM
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: gdal
Motivation
Resolves #25853
Details
Introduce new patch for gdal 3.7.3 (forward compatible with 3.8.3) which replaces empty
Parquet_VERSIONandArrowDataset_VERSIONvariables in CMake withARROW_VERSION.Arrow library always sets this variable, being the main dependency of gdal.
There is a PARQUET_VERSION var in Arrow source code, but it doesn't work during gdal configuration - probably because it's a template file which is included only when Arrow is built from source.
Configuration file of ArrowDataset doesn't even handle version variable.