Skip to content

Commit 96c479f

Browse files
authored
Merge pull request #77 from configcat/log-improvements
log no_match case + log feature flag evaluation on info level
2 parents db2ddc1 + 9e42a66 commit 96c479f

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

lib/config_cat/rollout.ex

+6-5
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ defmodule ConfigCat.Rollout do
8282
{:halt, {value, variation}}
8383

8484
{:ok, false} ->
85+
log_no_match(comparison_attribute, user_value, comparator, comparison_value)
8586
{:cont, default}
8687

8788
{:error, error} ->
@@ -138,23 +139,23 @@ defmodule ConfigCat.Rollout do
138139

139140
defp base_value(setting_descriptor, default_value) do
140141
result = Map.get(setting_descriptor, Constants.value(), default_value)
141-
Logger.debug("Returning #{result}")
142+
Logger.info("Returning #{result}")
142143

143144
result
144145
end
145146

146147
defp log_evaluating(key) do
147-
Logger.debug("Evaluating get_value('#{key}').")
148+
Logger.info("Evaluating get_value('#{key}').")
148149
end
149150

150151
defp log_match(comparison_attribute, user_value, comparator, comparison_value, value) do
151-
Logger.debug(
152+
Logger.info(
152153
"Evaluating rule: [#{comparison_attribute}:#{user_value}] [#{Comparator.description(comparator)}] [#{comparison_value}] => match, returning: #{value}"
153154
)
154155
end
155156

156157
defp log_no_match(comparison_attribute, user_value, comparator, comparison_value) do
157-
Logger.debug(
158+
Logger.info(
158159
"Evaluating rule: [#{comparison_attribute}:#{user_value}] [#{Comparator.description(comparator)}] [#{comparison_value}] => no match"
159160
)
160161
end
@@ -172,7 +173,7 @@ defmodule ConfigCat.Rollout do
172173
end
173174

174175
defp log_valid_user(user) do
175-
Logger.debug("User object: #{inspect(user)}")
176+
Logger.info("User object: #{inspect(user)}")
176177
end
177178

178179
defp log_nil_user(key) do

0 commit comments

Comments
 (0)