Skip to content

Commit ff1aaf5

Browse files
authored
Fix ListConsumerGroupOffsets not fetching offsets for all the topics in a group with Apache Kafka version below 2.4.0. (#4346)
1 parent 07262c4 commit ff1aaf5

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
librdkafka v2.2.1 is a maintenance release:
44

55
* Added Topic id to the metadata response which is part of the [KIP-516](https://cwiki.apache.org/confluence/display/KAFKA/KIP-516%3A+Topic+Identifiers)
6+
* Fixed ListConsumerGroupOffsets not fetching offsets for all the topics in a group with Apache Kafka version below 2.4.0.
67

78

89

src/rdkafka_request.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1180,7 +1180,7 @@ void rd_kafka_OffsetFetchRequest(rd_kafka_broker_t *rkb,
11801180
rkbuf, parts, rd_false /*include invalid offsets*/,
11811181
rd_false /*skip valid offsets */, fields);
11821182
} else {
1183-
rd_kafka_buf_write_arraycnt_pos(rkbuf);
1183+
rd_kafka_buf_write_arraycnt(rkbuf, PartCnt);
11841184
}
11851185

11861186
if (ApiVersion >= 7) {

tests/0081-admin.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4308,7 +4308,9 @@ static void do_test_apis(rd_kafka_type_t cltype) {
43084308
do_test_DeleteConsumerGroupOffsets(
43094309
"main queue", rk, mainq, 1500,
43104310
rd_true /*with subscribing consumer*/);
4311+
}
43114312

4313+
if (test_broker_version >= TEST_BRKVER(2, 5, 0, 0)) {
43124314
/* Alter committed offsets */
43134315
do_test_AlterConsumerGroupOffsets("temp queue", rk, NULL, -1,
43144316
rd_false, rd_true);
@@ -4321,7 +4323,9 @@ static void do_test_apis(rd_kafka_type_t cltype) {
43214323
"main queue", rk, mainq, 1500,
43224324
rd_true, /*with subscribing consumer*/
43234325
rd_true);
4326+
}
43244327

4328+
if (test_broker_version >= TEST_BRKVER(2, 0, 0, 0)) {
43254329
/* List committed offsets */
43264330
do_test_ListConsumerGroupOffsets("temp queue", rk, NULL, -1,
43274331
rd_false, rd_false);

0 commit comments

Comments
 (0)