cleanup

Author: connorjward

pyop3/lang.py

@@ -346,7 +346,7 @@ def _buffer_exchanges(buffer, intent, *, touches_ghost_points):
             # reductions
             assert intent in {INC, MIN_WRITE, MIN_RW, MAX_WRITE, MAX_RW}
             # We don't need to update roots if performing the same reduction
-            # again. For example we can increment into an buffer as many times
+            # again. For example we can increment into a buffer as many times
             # as we want. The reduction only needs to be done when the
             # data is read.
             if buffer._roots_valid or intent == buffer._pending_reduction:
@@ -360,16 +360,20 @@ def _buffer_exchanges(buffer, intent, *, touches_ghost_points):
                     assert buffer._pending_reduction is not None
                     initializers.append(buffer._reduce_leaves_to_roots_begin)
                     reductions.append(buffer._reduce_leaves_to_roots_end)
+
                 # set leaves to appropriate nil value
                 if intent == INC:
-                    def _zero():
-                        buffer._data[buffer.sf.ileaf] = 0
-                    reductions.append(_zero)
+                    nil = 0
                 elif intent in {MIN_WRITE, MIN_RW}:
-                    buffer._data[buffer.sf.ileaf] = dtype_limits(buffer.dtype).max
+                    nil = dtype_limits(buffer.dtype).max
                 else:
                     assert intent in {MAX_WRITE, MAX_RW}
-                    buffer._data[buffer.sf.ileaf] = dtype_limits(buffer.dtype).min
+                    nil = dtype_limits(buffer.dtype).min
+
+                def _init_nil():
+                    buffer._data[buffer.sf.ileaf] = nil
+
+                reductions.append(_init_nil)
 
             # We are modifying owned values so the leaves must now be wrong
             buffer._leaves_valid = False