Skip to content

[CI]: fix TestImageHistory to not hardcode duration #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
apostasie opened this issue Apr 1, 2025 · 4 comments
Closed

[CI]: fix TestImageHistory to not hardcode duration #4067

apostasie opened this issue Apr 1, 2025 · 4 comments
Assignees
@biubiubiuboomboomboom
Labels
area/ci e.g., CI failure bug Something isn't working good first issue Good for newcomers

Comments

@apostasie
Copy link
Contributor

Description

TestImageHistory currently fails every year, as it hard codes a string mentioning "created X years ago".

This was just temporarily addressed in #4058 but will fail again next year.

Steps to reproduce the issue

No response

Describe the results you received and expected

This test should be modified to remove the hard coded string so that it does not fail every year...

What version of nerdctl are you using?

main

Are you using a variant of nerdctl? (e.g., Rancher Desktop)

None

Host information

No response
@apostasie apostasie added the kind/unconfirmed-bug-claim Unconfirmed bug claim label Apr 1, 2025
@apostasie
Copy link
Contributor Author

@AkihiroSuda +good-first-issue

@AkihiroSuda AkihiroSuda added bug Something isn't working good first issue Good for newcomers area/ci e.g., CI failure and removed kind/unconfirmed-bug-claim Unconfirmed bug claim labels Apr 1, 2025
@apostasie apostasie changed the title CI: fix TestImageHistory to not hardcode duration [CI]: fix TestImageHistory to not hardcode duration Apr 1, 2025
@biubiubiuboomboomboom
Copy link

i'm interested in taking on this issue.

@apostasie
Copy link
Contributor Author

@biubiubiuboomboomboom sure, go for it! Thanks.

Merged
@apostasie
Copy link
Contributor Author

Fixed by #4083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@biubiubiuboomboomboom biubiubiuboomboomboom

Labels
area/ci e.g., CI failure bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AkihiroSuda @biubiubiuboomboomboom @apostasie