Skip to content

Commit 44ca009

Browse files
committed
Add comment
Signed-off-by: Maksym Pavlenko <[email protected]>
1 parent 6615f15 commit 44ca009

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

services.go

+4
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,10 @@ func (s *serviceSet) handle(ctx context.Context, req *Request, respond func(*sta
140140
respond(st, p, stream.StreamingServer, true)
141141
}()
142142

143+
// Empty proto messages serialized to 0 payloads,
144+
// so signatures like: rpc Stream(google.protobuf.Empty) returns (stream Data);
145+
// don't get invoked here, which causes hang on client side.
146+
// See https://github.com/containerd/ttrpc/issues/126
143147
if req.Payload != nil || !info.StreamingClient {
144148
unmarshal := func(obj interface{}) error {
145149
return protoUnmarshal(req.Payload, obj)

0 commit comments

Comments
 (0)