Fix for ensure_config + re-enable bootc revdep CI#207
Merged
cgwalters merged 2 commits intocomposefs:mainfrom Jan 9, 2026
Merged
Fix for ensure_config + re-enable bootc revdep CI#207cgwalters merged 2 commits intocomposefs:mainfrom
cgwalters merged 2 commits intocomposefs:mainfrom
Conversation
The ensure_config function was returning inconsistent values: - When config already exists: returned (config_digest, config_id) - When config is newly written: returned (content_id, config_id) The content_id has the 'oci-config-' prefix added, while config_digest does not. This caused downstream code (like bootc) to double-prefix the identifier when calling create_filesystem, resulting in paths like 'oci-config-oci-config-sha256:...' instead of 'oci-config-sha256:...'. Return the raw config_digest consistently in both cases. Assisted-by: OpenCode (Opus 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
The recent API changes in composefs-rs (splitstream rework, sync story) require corresponding updates in bootc. PR #1791 in bootc-dev/bootc contains those updates. Once that PR is merged, this should be changed back to track bootc main. Assisted-by: OpenCode (Opus 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
Collaborator
Author
🎉 |
allisonkarlitskaya
approved these changes
Jan 9, 2026
Collaborator
allisonkarlitskaya
left a comment
allisonkarlitskaya
left a comment
There was a problem hiding this comment.
Thanks for picking this up and updating the work in bootc-dev/bootc#1791 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.