Perform database changes after file changes

`getSingleCutoffGrid` can be run more than once on the same inputs. We should perform the database changes after all of the files are generated in case there is an error during one of the runs so that we could just run this again if needed.

Author: trevorgerhardt

src/main/java/com/conveyal/analysis/GenerateRegionalAnalysisResults.java

@@ -46,19 +46,12 @@ public void action(ProgressListener progressListener) throws Exception {
                 int[] cutoffs = Objects.requireNonNullElseGet(regionalAnalysis.cutoffsMinutes, () -> new int[]{regionalAnalysis.cutoffMinutes});
                 String[] destinationPointSetIds = Objects.requireNonNullElseGet(regionalAnalysis.destinationPointSetIds, () -> new String[]{regionalAnalysis.grid});
 
-                // Save as modern types
-                regionalAnalysis.cutoffsMinutes = cutoffs;
-                regionalAnalysis.travelTimePercentiles = percentiles;
-                regionalAnalysis.destinationPointSetIds = destinationPointSetIds;
-                Persistence.regionalAnalyses.put(regionalAnalysis);
-
                 // Iterate through all values and generate all possible formats for them.
                 for (String destinationPointSetId : destinationPointSetIds) {
                     OpportunityDataset destinations = Persistence.opportunityDatasets.get(destinationPointSetId);
                     for (int cutoffMinutes : cutoffs) {
                         for (int percentile : percentiles) {
                             for (FileStorageFormat format : validFormats) {
-                                filesGenerated++;
                                 RegionalAnalysisController.getSingleCutoffGrid(
                                         fileStorage,
                                         regionalAnalysis,
@@ -67,11 +60,18 @@ public void action(ProgressListener progressListener) throws Exception {
                                         percentile,
                                         format
                                 );
+                                filesGenerated++;
                             }
                         }
                     }
                 }
 
+                // Save as modern types
+                regionalAnalysis.cutoffsMinutes = cutoffs;
+                regionalAnalysis.travelTimePercentiles = percentiles;
+                regionalAnalysis.destinationPointSetIds = destinationPointSetIds;
+                Persistence.regionalAnalyses.put(regionalAnalysis);
+
                 LOG.info("Finished processing {} of {}.", regionalAnalysis._id, regionalAnalysis.accessGroup);
             }
         } catch (Exception e) {