iosrtc.enumerateDevices() call causes AVAudioSession to reset to its default settings

[soulfly]

Today I fought with a strange issue

By some reason, after upgraded to iOS 13 plugin version support, a switch audio output option stopped working in our app. Every time a user switches to speakerphone, it works ok, but only for some short period of time, then the audio output returns to earpiece.

After deep debugging, I noticed that every call to iosrtc.enumerateDevices() resets the audio session settings to default one.

The chain is the following:

1. https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/src/iosrtcPlugin.swift#L991
2. https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/src/PluginEnumerateDevices.swift#L28
3. https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/src/PluginEnumerateDevices.swift#L105
4. https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/src/PluginRTCAudioController.swift#L17

I think it should not be here and this one call in pluginInitialize to set default audio session settings should be enough https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/src/iosrtcPlugin.swift#L52

Otherwise it can produce unexpected things in users' apps

Platform information

• Cordova version:
  8.1.2

• Plugin version:
  latest master

• iOS version:
  13.2

• Xcode version:
  11.2

[hthetiot]

@soulfly thank you, I will look into it.

[hthetiot]

@soulfly Can you test this PR #439
If all good will be released in 6.0.3 tomorrow with #437

[soulfly]

I can confirm it works this way
@hthetiot thank you 🥇

[hthetiot]

@soulfly Released on #425 (comment)