Skip to content

Commit d3d5297

Browse files
jplexerclaude
andcommitted
fw/services/activity: use resource-id setter for insight tiny icon
AttributeIdIconTiny is a ResourceId-typed attribute, but the insight notification builder added it with attribute_list_add_uint32, producing the "Adding attribute with type uint32 for non-uint32_t attribute" warning in field logs on every insight notification. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Joshua Jun <lets@throw.rocks>
1 parent 700b2b0 commit d3d5297

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/fw/services/activity/activity_insights.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ static bool prv_save_state(ActivitySettingsKey key, void *val, size_t val_len) {
322322
static void prv_build_notification_attr_list(AttributeList *attr_list, const char *body,
323323
uint32_t icon, ActivityInsightType insight_type,
324324
ActivitySessionType activity_type) {
325-
attribute_list_add_uint32(attr_list, AttributeIdIconTiny, icon);
325+
attribute_list_add_resource_id(attr_list, AttributeIdIconTiny, icon);
326326
attribute_list_add_cstring(attr_list, AttributeIdBody, body);
327327
attribute_list_add_uint8(attr_list, AttributeIdBgColor, GColorOrangeARGB8);
328328
attribute_list_add_uint8(attr_list, AttributeIdHealthInsightType, insight_type);

0 commit comments

Comments
 (0)