Skip to content

Commit fe44cd3

Browse files
HuijingHeidustymabe
authored andcommitted
tests/ostree.sync: tag with "reprovision"
There is a race condition for `ostree.sync` and `kdump.crash.nfs` to bind port 2049, according to #4117 (comment), add tag `reprovision` to force them to run serially now.
1 parent f205254 commit fe44cd3

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

mantle/kola/tests/ignition/kdump.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,15 @@ func init() {
2828
Tags: []string{"kdump", kola.SkipBaseChecksTag, kola.NeedsInternetTag},
2929
Platforms: []string{"qemu"},
3030
})
31+
// Add tag "reprovision" to run serially to avoid NFS port conflicts.
32+
// This is hack until a better solution exists.
33+
// See https://github.com/coreos/coreos-assembler/issues/4117#issuecomment-3495048106
3134
register.RegisterTest(&register.Test{
3235
Run: kdumpNFSTest,
3336
ClusterSize: 0,
3437
Name: `kdump.crash.nfs`,
3538
Description: "Verifies kdump logs are exported to NFS destination",
36-
Tags: []string{"kdump", kola.SkipBaseChecksTag, kola.NeedsInternetTag},
39+
Tags: []string{"kdump", kola.SkipBaseChecksTag, kola.NeedsInternetTag, "reprovision"},
3740
Platforms: []string{"qemu"},
3841
})
3942
}

mantle/kola/tests/ostree/sync.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,17 @@ systemd:
7171
enabled: true`)
7272

7373
func init() {
74+
// See https://github.com/ostreedev/ostree/pull/2968
75+
// Add tag "reprovision" to run serially to avoid NFS port conflicts.
76+
// This is hack until a better solution exists.
77+
// See https://github.com/coreos/coreos-assembler/issues/4117#issuecomment-3495048106
7478
register.RegisterTest(&register.Test{
75-
// See https://github.com/ostreedev/ostree/pull/2968
7679
Run: ostreeSyncTest,
7780
ClusterSize: 0,
7881
Name: "ostree.sync",
7982
Description: "Verify ostree can sync the filesystem with disconnected the NFS volume.",
8083
Distros: []string{"rhcos"},
81-
Tags: []string{"ostree", kola.SkipBaseChecksTag, kola.NeedsInternetTag},
84+
Tags: []string{"ostree", kola.SkipBaseChecksTag, kola.NeedsInternetTag, "reprovision"},
8285
})
8386
}
8487

0 commit comments

Comments
 (0)