Skip to content

Conversation

@marmijo
Copy link
Member

@marmijo marmijo commented Nov 7, 2025

Fedora 43 now includes Python 3.14, so python3-osbuild installs into /usr/lib/python3.14/site-packages.

https://fedoraproject.org/wiki/Changes/Python3.14

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the osbuild path to point to the Python 3.14 site-packages directory, which is necessary for Fedora 43. While the change to the source path is correct, it is incomplete. I've identified a critical issue where the script attempts to move the osbuild directory back to the old Python 3.13 path after patching. This will cause the script to fail and must be corrected. I've left a specific comment with details on how to fix this. Additionally, please note that the Dockerfile is still based on fedora:42. You may need to update it to fedora:43 to ensure Python 3.14 is available in the build environment.

Fedora 43 now includes Python 3.14, so python3-osbuild installs into
/usr/lib/python3.14/site-packages.

https://fedoraproject.org/wiki/Changes/Python3.14
@marmijo
Copy link
Member Author

marmijo commented Nov 7, 2025

hmm, now that I think about it, CI on this PR will probably fail since main is using fedora42 which still has python3.13. I'll close this and add the commit to #4348

@marmijo marmijo closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant