refactor(CCloseButton): add type="button"

mrholek · mrholek · commit 5dcaecba5777 · 2022-05-23T10:27:39.000+02:00
diff --git a/packages/coreui-react/src/components/close-button/CCloseButton.tsx b/packages/coreui-react/src/components/close-button/CCloseButton.tsx
@@ -29,7 +29,14 @@ export const CCloseButton = forwardRef<HTMLButtonElement, CCloseButtonProps>(
       className,
     )
     return (
-      <button className={_className} aria-label="Close" disabled={disabled} {...rest} ref={ref} />
+      <button
+        type="button"
+        className={_className}
+        aria-label="Close"
+        disabled={disabled}
+        {...rest}
+        ref={ref}
+      />
     )
   },
 )

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,14 @@ export const CCloseButton = forwardRef<HTMLButtonElement, CCloseButtonProps>(`
`29`	`29`	`className,`
`30`	`30`	`)`
`31`	`31`	`return (`
`32`		`- <button className={_className} aria-label="Close" disabled={disabled} {...rest} ref={ref} />`
	`32`	`+ <button`
	`33`	`+ type="button"`
	`34`	`+ className={_className}`
	`35`	`+ aria-label="Close"`
	`36`	`+ disabled={disabled}`
	`37`	`+ {...rest}`
	`38`	`+ ref={ref}`
	`39`	`+ />`
`33`	`40`	`)`
`34`	`41`	`},`
`35`	`42`	`)`