Skip to content

Commit cfd5a08

Browse files
committed
address comment
Signed-off-by: yeya24 <[email protected]>
1 parent 568f1e7 commit cfd5a08

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pkg/compactor/blocks_cleaner.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ func NewBlocksCleaner(
165165
}, commonLabels),
166166
tenantParquetUnConvertedBlocks: promauto.With(reg).NewGaugeVec(prometheus.GaugeOpts{
167167
Name: "cortex_bucket_parquet_unconverted_blocks_count",
168-
Help: "Total number of parquet blocks in the bucket. Blocks marked for deletion are included.",
168+
Help: "Total number of unconverted parquet blocks in the bucket. Blocks marked for deletion are included.",
169169
}, commonLabels),
170170
tenantBlocksMarkedForDelete: promauto.With(reg).NewGaugeVec(prometheus.GaugeOpts{
171171
Name: "cortex_bucket_blocks_marked_for_deletion_count",

pkg/compactor/blocks_cleaner_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ func testBlocksCleanerWithOptions(t *testing.T, options testBlocksCleanerOptions
351351
# TYPE cortex_bucket_parquet_blocks_count gauge
352352
cortex_bucket_parquet_blocks_count{user="user-5"} 0
353353
cortex_bucket_parquet_blocks_count{user="user-6"} 1
354-
# HELP cortex_bucket_parquet_unconverted_blocks_count Total number of parquet blocks in the bucket. Blocks marked for deletion are included.
354+
# HELP cortex_bucket_parquet_unconverted_blocks_count Total number of unconverted parquet blocks in the bucket. Blocks marked for deletion are included.
355355
# TYPE cortex_bucket_parquet_unconverted_blocks_count gauge
356356
cortex_bucket_parquet_unconverted_blocks_count{user="user-5"} 0
357357
cortex_bucket_parquet_unconverted_blocks_count{user="user-6"} 0
@@ -1121,7 +1121,7 @@ func TestBlocksCleaner_ParquetMetrics(t *testing.T) {
11211121
`)))
11221122

11231123
require.NoError(t, prom_testutil.CollectAndCompare(cleaner.tenantParquetUnConvertedBlocks, strings.NewReader(`
1124-
# HELP cortex_bucket_parquet_unconverted_blocks_count Total number of parquet blocks in the bucket. Blocks marked for deletion are included.
1124+
# HELP cortex_bucket_parquet_unconverted_blocks_count Total number of unconverted parquet blocks in the bucket. Blocks marked for deletion are included.
11251125
# TYPE cortex_bucket_parquet_unconverted_blocks_count gauge
11261126
cortex_bucket_parquet_unconverted_blocks_count{user="user1"} 2
11271127
`)))

0 commit comments

Comments
 (0)