[4.x]:

[robinbeatty]

What happened?

Description

If the asset filesystem defined as the user photo filesystem has an environment variable as a subfolder path, the user photo returned (in our case by a graphql query) does not resolve the environment variable.

Instead we get asset paths like: https://dnncp3lgytrag.cloudfront.net/$S3_IMAGES_SUBFOLDER/user/sjoda_pullur.png

Other uses of the same filesystem correctly resolve the path.

Craft CMS version

4.16.4

PHP version

8.2

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

"born05/craft-assetusage": "^3.3",
"born05/craft-sentry": "3.0.0",
"carlcs/craft-uielementfields": "2.0.3",
"craftcms/aws-s3": "2.2.3",
"craftcms/cms": "4.16.4",
"craftcms/feed-me": "5.11.0",
"craftcms/mailgun": "3.1.0",
"craftcms/redactor": "3.1.0",
"doublesecretagency/craft-cpcss": "2.6.0",
"doublesecretagency/craft-cpjs": "^2.5",
"ether/simplemap": "4.0.8",
"jamesedmonston/graphql-authentication": "^2.5",
"nystudio107/craft-imageoptimize": "^4.0",
"nystudio107/craft-vite": "4.0.10",
"ostark/craft-async-queue": "3.2.1",
"putyourlightson/craft-campaign": "2.18.0",
"putyourlightson/craft-dashboard-begone": "^2.0",
"spicyweb/craft-quick-field": "2.0.8",
"symfony/mailgun-mailer": "^7.0",
"thomasvantuycom/craft-cloudinary": "1.7.2",
"verbb/field-manager": "3.0.9",
"vlucas/phpdotenv": "^5.4.0"

[linear]

CMS-1634

[brandonkelly]

Craft has never supported parsing environment variables mid-string, but I recently added support for it for Craft 5.9 (#17794), and I just went ahead and backported it for Craft 4.17 as well (#17949).

In the meantime, you’d need to define a new environment variable that contains the full URL up to /user/, e.g.

S3_IMAGES_URL=https://dnncp3lgytrag.cloudfront.net/${S3_IMAGES_SUBFOLDER}

And begin the setting with that environment variable instead:

$S3_IMAGES_URL/user/sjoda_pullur.png

[robinbeatty]

Thanks, but the variable is not mid string... the 'images' filesystem uses the S3 Assets plugin, and has a bucket subfolder path field set to $S3_IMAGES_SUBFOLDER (e.g. "images")

In users settings, the User Photo Location field is set to 'Images' filesystem, with 'user' subfolder path. I would expect the resulting URLs of user photo assets to be https://abcdefghikjk.cloudfront.net/images/user, but instead they are https://abcdefghikjk.cloudfront.net/$S3_IMAGES_SUBFOLDER/user. In other places in which this filesystem is called, the paths resolve correctly, just not in a user photo.

[robinbeatty]

Thanks also for the backport, will check that out – handy feature!

[brandonkelly]

Sorry, I misunderstood the issue.

I just tested this locally on 4.16.14, and it’s working as expected.

My filesystem is set to S3, with the Subfolder set to a path that begins with an environment variable. I’ve tested with and without a path appended after the environment variable.

I’ve also tested with and without a subfolder specified in my User Photo Location setting.

In all cases, I’m getting the expected URL in response to the GraphQL query:

query {
  users {
    photo {
      url
    }
  }
}

Couple things you can check:

• Make sure you’re on the latest releases of Craft and Amazon S3.
• Make sure the environment variable is actually defined on the server.
• If your User Photo Location setting has a subfolder, note that it must be hard-coded; this setting doesn’t support environment variables.