Skip to content

Commit 3c3183a

Browse files
committed
Improve supports_datetime_with_precision workaround
1 parent 6f6f4cc commit 3c3183a

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

lib/active_record/connection_adapters/crate_adapter.rb

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
require 'active_record'
2323
require 'active_record/base'
24-
require 'active_record/base'
2524
require 'arel/arel_crate'
2625
require 'arel/visitors/visitor'
2726
require 'active_support/dependencies/autoload'
@@ -126,14 +125,18 @@ def supports_migrations?
126125
true
127126
end
128127

128+
def supports_datetime_with_precision?
129+
true
130+
end
131+
129132
def connect
130133
@connection = CrateRuby::Client.new(["#{@host}:#{@port}"])
131134

132135
# Monkeypatch to make the client instance provide `supports_datetime_with_precision`.
133-
# FIXME: Implement within `CrateRuby::Client`.
136+
# FIXME: Implement within `CrateRuby::Client`?
137+
@adapter_supports_datetime_with_precision = supports_datetime_with_precision?
134138
def @connection.supports_datetime_with_precision?
135-
# TODO: Should it be `true` instead?
136-
return false
139+
return @adapter_supports_datetime_with_precision
137140
end
138141

139142
end

0 commit comments

Comments
 (0)