Skip to content

Commit a2a650e

Browse files
authored
Merge pull request #208 from adrianriobo/fix-189
Show Full User Experience When Running The Installer On Windows
2 parents ef6facc + 1c3864a commit a2a650e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/extension.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ async function initializeCrc(
289289
telemetryLogger: extensionApi.TelemetryLogger,
290290
logger: extensionApi.Logger,
291291
): Promise<boolean> {
292-
const hasSetupFinished = await setUpCrc(logger, false);
292+
const hasSetupFinished = await setUpCrc(logger, true);
293293
if (hasSetupFinished) {
294294
await needSetup();
295295
await connectToCrc();

src/install/win-install.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export class WinInstall extends BaseInstaller {
4141
msiPath = await this.extractMsiFromZip(setupPath);
4242
progress.report({ increment: 10 });
4343

44-
const runResult = await runCliCommand('msiexec.exe', ['/i', msiPath, '/qr', '/norestart']);
44+
const runResult = await runCliCommand('msiexec.exe', ['/i', msiPath, '/qf']);
4545
if (runResult.exitCode !== 0) {
4646
// installed successfully, but reboot required
4747
if (runResult.exitCode === 3010) {

0 commit comments

Comments
 (0)