Refactor production config to frozen and install_development

Author: straight-shoota

src/cli.cr

@@ -30,7 +30,10 @@ module Shards
 
       opts.on("--no-color", "Disable colored output.") { self.colors = false }
       opts.on("--version", "Print the `shards` version.") { puts self.version_string; exit }
-      opts.on("--production", "Run in release mode. No development dependencies and strict sync between shard.yml and shard.lock.") { self.production = true }
+      opts.on("--production", "Run in release mode. No development dependencies and strict sync between shard.yml and shard.lock.") do
+        self.frozen = true
+        self.with_development = false
+      end
       opts.on("--local", "Don't update remote repositories, use the local cache only.") { self.local = true }
       opts.on("--ignore-crystal-version", "Do not enforce crystal version restrictions on shards.") { self.ignore_crystal_version = true }
       opts.on("-v", "--verbose", "Increase the log verbosity, printing all debug statements.") { self.set_debug_log_level }

src/commands/check.cr

@@ -8,14 +8,14 @@ module Shards
         if has_dependencies?
           locks # ensures that lockfile exists
           verify(spec.dependencies)
-          verify(spec.development_dependencies) unless Shards.production?
+          verify(spec.development_dependencies) if Shards.with_development?
         end
 
         Log.info { "Dependencies are satisfied" }
       end
 
       private def has_dependencies?
-        spec.dependencies.any? || (!Shards.production? && spec.development_dependencies.any?)
+        spec.dependencies.any? || (Shards.with_development? && spec.development_dependencies.any?)
       end
 
       private def verify(dependencies)

src/commands/install.cr

@@ -14,19 +14,19 @@ module Shards
           solver.locks = locks.shards
         end
 
-        solver.prepare(development: !Shards.production?)
+        solver.prepare(development: Shards.with_development?)
 
         packages = handle_resolver_errors { solver.solve }
 
-        if lockfile? && Shards.production?
+        if lockfile? && Shards.frozen?
           validate(packages)
         end
 
         install(packages)
 
         if generate_lockfile?(packages)
           write_lockfile(packages)
-        elsif !Shards.production?
+        elsif !Shards.frozen?
           # Touch lockfile so its mtime is bigger than that of shard.yml
           File.touch(lockfile_path)
         end
@@ -87,7 +87,7 @@ module Shards
       end
 
       private def generate_lockfile?(packages)
-        !Shards.production? && (!lockfile? || outdated_lockfile?(packages))
+        !Shards.frozen? && (!lockfile? || outdated_lockfile?(packages))
       end
 
       private def outdated_lockfile?(packages)

src/commands/list.cr

@@ -9,7 +9,7 @@ module Shards
         return unless has_dependencies?
         puts "Shards installed:"
         list(spec.dependencies)
-        list(spec.development_dependencies) unless Shards.production?
+        list(spec.development_dependencies) if Shards.with_development?
       end
 
       private def list(dependencies, level = 1)
@@ -30,7 +30,7 @@ module Shards
 
       # FIXME: duplicates Check#has_dependencies?
       private def has_dependencies?
-        spec.dependencies.any? || (!Shards.production? && spec.development_dependencies.any?)
+        spec.dependencies.any? || (Shards.with_development? && spec.development_dependencies.any?)
       end
     end
   end

src/commands/lock.cr

@@ -22,7 +22,7 @@ module Shards
           end
         end
 
-        solver.prepare(development: !Shards.production?)
+        solver.prepare(development: Shards.with_development?)
 
         packages = handle_resolver_errors { solver.solve }
         return if packages.empty?

src/commands/outdated.cr

@@ -14,7 +14,7 @@ module Shards
         Log.info { "Resolving dependencies" }
 
         solver = MolinilloSolver.new(spec, override, prereleases: @prereleases, ignore_crystal_version: ignore_crystal_version)
-        solver.prepare(development: !Shards.production?)
+        solver.prepare(development: Shards.with_development?)
 
         packages = handle_resolver_errors { solver.solve }
         packages.each { |package| analyze(package) }
@@ -110,7 +110,7 @@ module Shards
 
       # FIXME: duplicates Check#has_dependencies?
       private def has_dependencies?
-        spec.dependencies.any? || (!Shards.production? && spec.development_dependencies.any?)
+        spec.dependencies.any? || (Shards.with_development? && spec.development_dependencies.any?)
       end
 
       private def dependency_by_name(name : String)

src/commands/update.cr

@@ -15,7 +15,7 @@ module Shards
           solver.locks = locks.shards.reject { |d| shards.includes?(d.name) }
         end
 
-        solver.prepare(development: !Shards.production?)
+        solver.prepare(development: Shards.with_development?)
 
         packages = handle_resolver_errors { solver.solve }
         install(packages)
@@ -60,7 +60,7 @@ module Shards
       end
 
       private def generate_lockfile?(packages)
-        !Shards.production?
+        !Shards.frozen?
       end
     end
   end

src/config.cr

@@ -94,7 +94,8 @@ module Shards
     end
   end
 
-  class_property? production = false
+  class_property? frozen = false
+  class_property? with_development = true
   class_property? local = false
   class_property? ignore_crystal_version = false
 end