Let frozen fail when shard.lock is missing

Author: straight-shoota

Diff for: spec/integration/install_spec.cr

@@ -540,22 +540,19 @@ describe "install" do
         dependencies:             {web: "*", orm: "*"},
         development_dependencies: {mock: "*"},
       }
+      # --production requires a lock file because it implies --frozen
+      lock = {web: "1.0.0", orm: "0.3.0"}
 
-      with_shard(metadata) do
-        File.exists?(File.join(application_path, "shard.lock")).should be_false
+      with_shard(metadata, lock) do
         run "shards install --production"
 
         # it installed dependencies (recursively)
         assert_installed "web"
         assert_installed "orm"
-        assert_installed "pg"
 
         # it didn't install development dependencies
         refute_installed "mock"
         refute_installed "minitest"
-
-        # it didn't generate lock file
-        File.exists?(File.join(application_path, "shard.lock")).should be_false
       end
     end
   end

Diff for: spec/integration/list_spec.cr

@@ -23,14 +23,16 @@ describe "list" do
       dependencies:             {web: "*", orm: "*"},
       development_dependencies: {mock: "*"},
     }
-    with_shard(metadata) do
+    # --production requires a lock file because it implies --frozen
+    lock = {web: "1.0.0", orm: "0.3.0"}
+
+    with_shard(metadata, lock) do
       run "shards install --production"
       stdout = run "shards list --production"
-      stdout.should contain("web (2.1.0)")
-      stdout.should contain("orm (0.5.0)")
-      stdout.should contain("pg (0.2.1)")
-      stdout.should_not contain("mock (0.1.0)")
-      stdout.should_not contain("shoulda (0.1.0)")
+      stdout.should contain("web (1.0.0)")
+      stdout.should contain("orm (0.3.0)")
+      stdout.should_not contain("mock")
+      stdout.should_not contain("shoulda")
     end
   end
 

Diff for: src/commands/install.cr

@@ -5,6 +5,10 @@ module Shards
   module Commands
     class Install < Command
       def run(*, ignore_crystal_version = false)
+        if Shards.frozen? && !lockfile?
+          raise Error.new("Missing shard.lock")
+        end
+
         Log.info { "Resolving dependencies" }
 
         solver = MolinilloSolver.new(spec, override, ignore_crystal_version: ignore_crystal_version)
@@ -18,7 +22,7 @@ module Shards
 
         packages = handle_resolver_errors { solver.solve }
 
-        if lockfile? && Shards.frozen?
+        if Shards.frozen?
           validate(packages)
         end