Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/refine/split --production option #452

Open
straight-shoota opened this issue Dec 7, 2020 · 0 comments
Open

Rename/refine/split --production option #452

straight-shoota opened this issue Dec 7, 2020 · 0 comments

Comments

@straight-shoota
Copy link
Member

straight-shoota commented Dec 7, 2020

The --production option is not very appropriately named because it's easy to assume it means running shards (especially shards build in "production mode"). Instead, its behaviour is only related to dependency resolution (and even that is not strongly tied to production environments). It has two effects which should be available as separate options. For example, in a CI environment you may want to install only from lockfile but also install development dependencies.

  • --frozen: only install locked dependencies and fail if shard.yml contradicts shard.lock
  • --without-development: don't install development dependencies
  • --deployment: The combination of the above (currently --production)

The latter could stay as --production, but I'd rather have a better fitting name. --deployment is used by bundler, too. This should also fail if shard.lock is missing (also like bundler).

Related to #372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant