[CW2-36] Linking Merch Store Link in nav bar and hamburger #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekxu04
suggested changes
Jul 12, 2024
frontend/src/components/Navbar.tsx
Outdated
| @@ -40,6 +40,16 @@ const Navbar = () => { | |||
| <Link href="/contact-us"> | |||
| <div className="text-xl">{'//'} contact us</div> | |||
| </Link> | |||
| <a href="https://csesoc-merch.square.site/" className='flex xl:gap-3 lg:gap-1.5 md:gap-0.8 duration-300 hover:scale-105'> | |||
There was a problem hiding this comment.
I think just get rid of the text and just have the icon, otherwise it's too much
Also, maybe make it so that the link opens in a new tab
There was a problem hiding this comment.
Also thinking about it now, I think from experience navbars generally don't really have animations? Idk, just my opinion
| @@ -50,6 +50,9 @@ export default function Hamburger() { | |||
| <li className="py-2 text-lg"> | |||
| <Link href={'./contact-us'}>Contact Us</Link> | |||
| </li> | |||
| <li className="py-2 text-lg"> | |||
| <a href="https://csesoc-merch.square.site/">Merchandise</a> | |||
There was a problem hiding this comment.
Maybe call this merch store
derekxu04
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: