Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test prefix from session id? #264

Open
ctreffe opened this issue Feb 21, 2024 · 1 comment
Open

Remove test prefix from session id? #264

ctreffe opened this issue Feb 21, 2024 · 1 comment
Labels
help wanted Additional information is needed improvement Refinement of existing feature

Comments

@ctreffe
Copy link
Owner

ctreffe commented Feb 21, 2024

Currently, alfred still adds a "test" prefix to session ids in test sessions. This does not cause any problems, but technically it is not necessary anymore. Is there any reason to keep a test prefix on both the exp_version and the session_id variables?

@ctreffe ctreffe added improvement Refinement of existing feature help wanted Additional information is needed labels Feb 21, 2024
@jobrachem
Copy link
Collaborator

In the spirit of "there should be one way it is done", I agree in principle that we can remove this prefix in the future. It may lead to users relying on the session ID prefix instead of the version prefix, which is something we do not want. However, backwards compatibility would be much better if we just let it sit there. Maybe, to achieve consistency, we should rather also add a "debug" prefix to session ids in debug mode (if there is no such prefix at the moment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Additional information is needed improvement Refinement of existing feature
Projects
None yet
Development

No branches or pull requests

2 participants