Skip to content

Commit 4550119

Browse files
gve: prevent ethtool ops after shutdown
jira KERNEL-1218 commit-author Jordan Rhee <jordanrhee@google.com> commit 75a9a46 A crash can occur if an ethtool operation is invoked after shutdown() is called. shutdown() is invoked during system shutdown to stop DMA operations without performing expensive deallocations. It is discouraged to unregister the netdev in this path, so the device may still be visible to userspace and kernel helpers. In gve, shutdown() tears down most internal data structures. If an ethtool operation is dispatched after shutdown(), it will dereference freed or NULL pointers, leading to a kernel panic. While graceful shutdown normally quiesces userspace before invoking the reboot syscall, forced shutdowns (as observed on GCP VMs) can still trigger this path. Fix by calling netif_device_detach() in shutdown(). This marks the device as detached so the ethtool ioctl handler will skip dispatching operations to the driver. Fixes: 974365e ("gve: Implement suspend/resume/shutdown") Signed-off-by: Jordan Rhee <jordanrhee@google.com> Signed-off-by: Jeroen de Borst <jeroendb@google.com> Link: https://patch.msgid.link/20250818211245.1156919-1-jeroendb@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> (cherry picked from commit 75a9a46) Signed-off-by: Shreeya Patel <spatel@ciq.com>
1 parent 4543933 commit 4550119

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/net/ethernet/google/gve/gve_main.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2643,6 +2643,8 @@ static void gve_shutdown(struct pci_dev *pdev)
26432643
struct gve_priv *priv = netdev_priv(netdev);
26442644
bool was_up = netif_running(priv->dev);
26452645

2646+
netif_device_detach(netdev);
2647+
26462648
rtnl_lock();
26472649
if (was_up && gve_close(priv->dev)) {
26482650
/* If the dev was up, attempt to close, if close fails, reset */

0 commit comments

Comments
 (0)