Update AddPolicy

Signed-off-by: Craig Perkins <[email protected]>

Author: cwperks

src/main/kotlin/org/opensearch/indexmanagement/indexstatemanagement/transport/action/addpolicy/TransportAddPolicyAction.kt

@@ -58,13 +58,13 @@ import org.opensearch.indexmanagement.opensearchapi.withClosableContext
 import org.opensearch.indexmanagement.settings.IndexManagementSettings
 import org.opensearch.indexmanagement.spi.indexstatemanagement.model.ISMIndexMetadata
 import org.opensearch.indexmanagement.util.IndexUtils
-import org.opensearch.indexmanagement.util.PluginClient
 import org.opensearch.indexmanagement.util.SecurityUtils.Companion.buildUser
 import org.opensearch.indexmanagement.util.SecurityUtils.Companion.userHasPermissionForResource
 import org.opensearch.indexmanagement.util.SecurityUtils.Companion.validateUserConfiguration
 import org.opensearch.tasks.Task
 import org.opensearch.transport.TransportService
 import org.opensearch.transport.client.Client
+import org.opensearch.transport.client.node.NodeClient
 import java.time.Duration
 import java.time.Instant
 
@@ -74,7 +74,7 @@ private val log = LogManager.getLogger(TransportAddPolicyAction::class.java)
 class TransportAddPolicyAction
 @Inject
 constructor(
-    val client: PluginClient,
+    val client: NodeClient,
     transportService: TransportService,
     actionFilters: ActionFilters,
     val settings: Settings,

src/main/kotlin/org/opensearch/indexmanagement/indexstatemanagement/transport/action/explain/TransportExplainAction.kt

@@ -388,12 +388,11 @@ constructor(
             if (user == null || indexNames.isEmpty()) {
                 sendResponse(indexNames, indexMetadatas, indexPolicyIDs, enabledState, totalManagedIndices, appliedPolicies, validationResults)
             } else {
-                filterAndSendResponse(threadContext)
+                filterAndSendResponse()
             }
         }
 
-        private fun filterAndSendResponse(threadContext: ThreadContext.StoredContext) {
-            threadContext.restore()
+        private fun filterAndSendResponse() {
             val filteredIndices = mutableListOf<String>()
             val filteredMetadata = mutableListOf<ManagedIndexMetaData?>()
             val filteredValidationResult = mutableListOf<ValidationResult?>()

src/main/resources/plugin-additional-permissions.yml

@@ -9,5 +9,5 @@ index_permissions:
     allowed_actions:
       - "indices:data/read/search*"
       - "indices:admin/settings/update"
-      - "indices:admin/opensearch/ism/managedindex"
+      # - "indices:admin/opensearch/ism/managedindex"
       # - "indices:admin/delete"