Skip to content

Commit 744d9b6

Browse files
authored
chore: fix sinon-chai relative path rewrite as it is breaking type checking in the cypress cli externally (#31733)
1 parent 7419934 commit 744d9b6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.circleci/workflows.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ mainBuildFilters: &mainBuildFilters
3838
- /^release\/\d+\.\d+\.\d+$/
3939
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
4040
- 'update-v8-snapshot-cache-on-develop'
41-
- 'misc/throw_error_on_extension_chrome_137'
41+
- 'misc/chore/fix_sinon_chai_rewrite'
4242

4343
# usually we don't build Mac app - it takes a long time
4444
# but sometimes we want to really confirm we are doing the right thing

cli/scripts/post-install.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ makeReferenceTypesCommentRelative('chai', '../chai/index.d.ts', sinonChaiFilenam
7171
makeReferenceTypesCommentRelative('sinon', '../sinon/index.d.ts', sinonChaiFilename)
7272

7373
// and an import sinon line to be changed to relative path
74-
shell.sed('-i', 'from \'sinon\';', 'from \'../sinon\';', sinonChaiFilename)
74+
shell.sed('-i', 'from \"sinon\";', 'from \"../sinon\";', sinonChaiFilename)
7575

7676
// copy experimental network stubbing type definitions
7777
// so users can import: `import 'cypress/types/net-stubbing'`

0 commit comments

Comments
 (0)