Skip to content

Commit b09d393

Browse files
authored
test: fix version on wait-on for react-scripts (#820)
Increase timeout to 60 seconds Update README example to 60 seconds
1 parent 249883b commit b09d393

File tree

6 files changed

+393
-32
lines changed

6 files changed

+393
-32
lines changed

.github/workflows/example-wait-on.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ jobs:
157157
working-directory: examples/v9/react-scripts
158158
start: npm start
159159
# let's use wait-on NPM package to check the URL
160-
wait-on: 'npx wait-on --timeout 5000 http://127.0.0.1:3000'
160+
wait-on: 'npx wait-on --timeout 60000 http://127.0.0.1:3000'
161161

162162
ping-cli-v9:
163163
runs-on: ubuntu-22.04
@@ -330,7 +330,7 @@ jobs:
330330
working-directory: examples/react-scripts
331331
start: npm start
332332
# let's use wait-on NPM package to check the URL
333-
wait-on: 'npx wait-on --timeout 5000 http://127.0.0.1:3000'
333+
wait-on: 'npx wait-on --timeout 60000 http://127.0.0.1:3000'
334334

335335
ping-cli:
336336
runs-on: ubuntu-22.04

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -755,7 +755,7 @@ You can even use your own command (usually by using `npm`, `yarn`, `npx`) to wai
755755
- uses: cypress-io/github-action@v5
756756
with:
757757
start: npm start
758-
wait-on: 'npx wait-on --timeout 5000 http://localhost:3000'
758+
wait-on: 'npx wait-on --timeout 60000 http://localhost:3000'
759759
```
760760

761761
See [example-wait-on.yml](.github/workflows/example-wait-on.yml) workflow file.

examples/react-scripts/package-lock.json

+207-26
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/react-scripts/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
"cypress": "12.8.0",
1313
"react": "^18.2.0",
1414
"react-dom": "^18.2.0",
15-
"react-scripts": "^5.0.1"
15+
"react-scripts": "^5.0.1",
16+
"wait-on": "^7.0.1"
1617
},
1718
"browserslist": {
1819
"production": [

0 commit comments

Comments
 (0)