Skip to content

Commit e3d39f5

Browse files
authored
test: fix example-recording failure reporting status (#1073)
1 parent 6b9646b commit e3d39f5

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

.github/workflows/example-recording.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ jobs:
5555
# let's give this action an ID so we can refer
5656
# to its output values later
5757
id: cypress
58-
# Continue the build in case of an error, as we need to set the
59-
# commit status in the next step, both in case of success and failure
60-
continue-on-error: true
6158
with:
6259
working-directory: examples/recording
6360
record: true
@@ -69,6 +66,7 @@ jobs:
6966
# https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#steps-context
7067
# "output" can be success, failure, cancelled, or skipped
7168
- name: Print Cypress Cloud URL
69+
if: always()
7270
run: |
7371
echo Cypress finished with: ${{ steps.cypress.outcome }}
7472
echo See results at ${{ steps.cypress.outputs.resultsUrl }}

README.md

+1-3
Original file line numberDiff line numberDiff line change
@@ -1370,14 +1370,12 @@ This is an example of using the step output `resultsUrl`:
13701370
# let's give this action an ID so we can refer
13711371
# to its output values later
13721372
id: cypress
1373-
# Continue the build in case of an error, as we need to set the
1374-
# commit status in the next step, both in case of success or failure
1375-
continue-on-error: true
13761373
with:
13771374
record: true
13781375
env:
13791376
CYPRESS_RECORD_KEY: ${{ secrets.RECORDING_KEY }}
13801377
- name: Print Cypress Cloud URL
1378+
if: always()
13811379
run: |
13821380
echo Cypress finished with: ${{ steps.cypress.outcome }}
13831381
echo See results at ${{ steps.cypress.outputs.resultsUrl }}

0 commit comments

Comments
 (0)