feat: allow testing preBuild site

Author: bahmutov

manifest.yml

@@ -1,5 +1,7 @@
 name: netlify-plugin-cypress
 inputs:
+  # these settings apply during postBuild step
+  # when we are testing the site served from the distribution folder
   - name: record
     default: false
   - name: spec

netlify.toml

@@ -11,9 +11,9 @@ publish = "public"
 [[plugins]]
   # local Cypress plugin will test our site after it is built
   package = "."
-  [plugins.inputs]
-  spec = 'cypress/integration/spec.js'
-  [plugins.inputs.preBuild]
-    start = 'npm start'
-    wait-on = 'http://localhost:5000'
-    wait-on-timeout = '3' # seconds
+  # [plugins.inputs]
+  # spec = 'cypress/integration/spec.js'
+  # [plugins.inputs.preBuild]
+  #   start = 'npm start'
+  #   wait-on = 'http://localhost:5000'
+  #   wait-on-timeout = '3' # seconds

package-lock.json

@@ -17,10 +17,12 @@
   "license": "ISC",
   "dependencies": {
     "argument-vector": "1.0.2",
+    "check-more-types": "2.24.0",
     "debug": "4.1.1",
     "ecstatic": "4.1.2",
     "execa": "3.4.0",
-    "got": "9.6.0"
+    "got": "9.6.0",
+    "lazy-ass": "1.6.0"
   },
   "repository": {
     "type": "git",

package.json

@@ -4,6 +4,8 @@ const http = require('http')
 const execa = require('execa')
 const debug = require('debug')('netlify-plugin-cypress')
 const debugVerbose = require('debug')('netlify-plugin-cypress:verbose')
+const la = require('lazy-ass')
+const is = require('check-more-types')
 const { ping } = require('./utils')
 
 function serveFolder (folder, port) {
@@ -133,11 +135,6 @@ async function postBuild({ fullPublishFolder, record, spec, failBuild }) {
   processCypressResults(results, failBuild)
 }
 
-const throwAnError = (message, info) => {
-  console.error('Exit with error: %s', message)
-  throw info.error
-}
-
 const hasRecordKey = () => typeof process.env.CYPRESS_RECORD_KEY === 'string'
 
 module.exports = function cypressPlugin (pluginConfig) {
@@ -170,7 +167,8 @@ module.exports = function cypressPlugin (pluginConfig) {
         closeServer()
       }
 
-      const failBuild = arg.utils && arg.utils.build && arg.utils.build.failBuild || throwAnError
+      const failBuild = arg.utils && arg.utils.build && arg.utils.build.failBuild
+      la(is.fn(failBuild), 'expected failBuild function inside', arg.utils)
 
       processCypressResults(results, failBuild)
     },
@@ -188,7 +186,8 @@ module.exports = function cypressPlugin (pluginConfig) {
 
       const spec = pluginConfig.spec
 
-      const failBuild = arg.utils && arg.utils.build && arg.utils.build.failBuild || throwAnError
+      const failBuild = arg.utils && arg.utils.build && arg.utils.build.failBuild
+      la(is.fn(failBuild), 'expected failBuild function inside', arg.utils)
 
       return postBuild({
         fullPublishFolder,