Annotate ~PyDataTable with override, add NOLINT to read_element

dagardner-nv · dagardner-nv · commit e71c19e7559e · 2024-11-01T18:34:42.000-07:00
diff --git a/python/morpheus/morpheus/_lib/include/morpheus/objects/python_data_table.hpp b/python/morpheus/morpheus/_lib/include/morpheus/objects/python_data_table.hpp
@@ -44,7 +44,7 @@ struct PyDataTable : public IDataTable
      * @param py_table
      */
     PyDataTable(pybind11::object&& py_table);
-    ~PyDataTable();
+    ~PyDataTable() override;
 
     /**
      * @brief cuDF table rows count
diff --git a/python/morpheus/morpheus/_lib/include/morpheus/objects/tensor_object.hpp b/python/morpheus/morpheus/_lib/include/morpheus/objects/tensor_object.hpp
@@ -294,7 +294,7 @@ struct TensorObject final
     }
 
     template <typename T, RankType N>
-    T read_element(const TensorIndex (&idx)[N]) const
+    T read_element(const TensorIndex (&idx)[N]) const  // NOLINT(modernize-avoid-c-arrays)
     {
         auto stride = this->get_stride();
         auto shape  = this->get_shape();

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ struct TensorObject final`
`294`	`294`	`}`
`295`	`295`
`296`	`296`	`template <typename T, RankType N>`
`297`		`- T read_element(const TensorIndex (&idx)[N]) const`
	`297`	`+ T read_element(const TensorIndex (&idx)[N]) const // NOLINT(modernize-avoid-c-arrays)`
`298`	`298`	`{`
`299`	`299`	`auto stride = this->get_stride();`
`300`	`300`	`auto shape = this->get_shape();`