Image rendering issues with some links

[dsaxton]

This note has an image that doesn't render in Notedeck (actually no links posted by this npub seem to work): https://njump.me/nevent1qqswqeyqmut9sspe4vfn006fuwpe96g40ww2jax4c77cdlhefn4fzdgpz4mhxue69uhhyetvv9ujuerpd46hxtnfduhsygr3aj4a3d4nx4ywqa0lqxe3268lmgvaptp83qr8mxfj33k7fzzew5psgqqqqqqs9r6rsf

Interestingly while Amethyst is able to display the image it fails to download when you go to manually save because it gets confused by the content type. Maybe it's a similar issue here.

The image is from S3 and has these headers for what it's worth:

$ curl -I https://smartflowsocial.s3.us-east-1.amazonaws.com/clients/cm7kdrwdk0000qyu6fwtd96ui/e24d5480-12b7-4385-a2ed-e24a350924a6.jpg
HTTP/1.1 200 OK
x-amz-id-2: mfsf6S5SRTpriUFy1topLGsrgBNbWZ/idEvQnHa+T0lb9BZK4BhrCZa9b6oaDdfKoWm1u7CBsIY=
x-amz-request-id: EG78BWXCXN05R26T
Date: Mon, 10 Mar 2025 01:44:29 GMT
Last-Modified: Sun, 02 Mar 2025 15:12:06 GMT
ETag: "4262ee5125ef80e4bbea1cf85af8b1d2"
x-amz-server-side-encryption: AES256
Accept-Ranges: bytes
Content-Type: application/octet-stream
Content-Length: 81697
Server: AmazonS3

[linear]

DECK-547 Image rendering issues with some links

[dsaxton]

It's possible this is not a bug since we're explicitly looking for specific image content types:

notedeck/crates/notedeck_columns/src/images.rs

Lines 170 to 185 in d85c604

	if content_type.starts_with("image/svg") {
	#[cfg(feature = "profiling")]
	puffin::profile_scope!("load_svg");
	let mut color_image =
	egui_extras::image::load_svg_bytes_with_size(&response.bytes, Some(size_hint))?;
	round_image(&mut color_image);
	Ok(color_image)
	} else if content_type.starts_with("image/") {
	#[cfg(feature = "profiling")]
	puffin::profile_scope!("load_from_memory");
	let dyn_image = image::load_from_memory(&response.bytes)?;
	Ok(process_pfp_bitmap(imgtyp, dyn_image))
	} else {
	Err(format!("Expected image, found content-type {:?}", content_type).into())
	}

Trying to render arbitrary binary data may not be good.

[kernelkind]

yeah it's content-type is application/octet-stream which is for arbitrary binary data, I wouldn't consider it a bug