Skip to content

Commit d26a120

Browse files
echarrodecharrod
committed
danger-js: Update func names
1 parent 76e4297 commit d26a120

File tree

2 files changed

+69
-69
lines changed

2 files changed

+69
-69
lines changed

‎build/ci/dangerfile.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ import (
88

99
// Run is invoked by danger-go
1010
func Run(d *danger.T, pr danger.DSL) {
11-
d.Message(fmt.Sprintf("%d new files added!", len(pr.Git.GetCreatedFiles())), "", 0)
12-
d.Message(fmt.Sprintf("%d files modified!", len(pr.Git.GetModifiedFiles())), "", 0)
11+
d.Message(fmt.Sprintf("%d new files added!", len(pr.Git.CreatedFiles())), "", 0)
12+
d.Message(fmt.Sprintf("%d files modified!", len(pr.Git.ModifiedFiles())), "", 0)
1313
}

‎danger-js/types_danger.go‎

Lines changed: 67 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -24,33 +24,33 @@ var (
2424
)
2525

2626
type GitHub interface {
27-
GetIssue() GitHubIssue
28-
GetPR() GitHubPR
29-
GetThisPR() GitHubAPIPR
30-
GetCommits() []GitHubCommit
31-
GetReviews() []GitHubReview
32-
GetRequestedReviewers() GitHubReviewers
27+
Issue() GitHubIssue
28+
PR() GitHubPR
29+
ThisPR() GitHubAPIPR
30+
Commits() []GitHubCommit
31+
Reviews() []GitHubReview
32+
RequestedReviewers() GitHubReviewers
3333
}
3434

3535
type GitLab interface {
36-
GetMetadata() RepoMetaData
37-
GetMR() GitLabMR
38-
GetCommits() []GitLabMRCommit
39-
GetApprovals() GitLabApproval
36+
Metadata() RepoMetaData
37+
MR() GitLabMR
38+
Commits() []GitLabMRCommit
39+
Approvals() GitLabApproval
4040
}
4141

4242
type Settings interface {
43-
GetGitHubAccessToken() string
44-
GetGitHubBaseURL() string
45-
GetGitHubAdditionalHeaders() any
46-
GetCLIArgs() CLIArgs
43+
GitHubAccessToken() string
44+
GitHubBaseURL() string
45+
GitHubAdditionalHeaders() any
46+
CLIArgs() CLIArgs
4747
}
4848

4949
type Git interface {
50-
GetModifiedFiles() []FilePath
51-
GetCreatedFiles() []FilePath
52-
GetDeletedFiles() []FilePath
53-
GetCommits() []GitCommit
50+
ModifiedFiles() []FilePath
51+
CreatedFiles() []FilePath
52+
DeletedFiles() []FilePath
53+
Commits() []GitCommit
5454
DiffForFile(filePath string) (FileDiff, error)
5555
DiffForFileWithRefs(filePath, baseRef, headRef string) (FileDiff, error)
5656
}
@@ -67,26 +67,26 @@ type FilePath = string
6767

6868
// gitImpl is the internal implementation of the Git interface
6969
type gitImpl struct {
70-
ModifiedFiles []FilePath `json:"modified_files"`
71-
CreatedFiles []FilePath `json:"created_files"`
72-
DeletedFiles []FilePath `json:"deleted_files"`
73-
Commits []GitCommit `json:"commits"`
70+
ModifiedFilesList []FilePath `json:"modified_files"`
71+
CreatedFilesList []FilePath `json:"created_files"`
72+
DeletedFilesList []FilePath `json:"deleted_files"`
73+
CommitsList []GitCommit `json:"commits"`
7474
}
7575

76-
func (g gitImpl) GetModifiedFiles() []FilePath {
77-
return g.ModifiedFiles
76+
func (g gitImpl) ModifiedFiles() []FilePath {
77+
return g.ModifiedFilesList
7878
}
7979

80-
func (g gitImpl) GetCreatedFiles() []FilePath {
81-
return g.CreatedFiles
80+
func (g gitImpl) CreatedFiles() []FilePath {
81+
return g.CreatedFilesList
8282
}
8383

84-
func (g gitImpl) GetDeletedFiles() []FilePath {
85-
return g.DeletedFiles
84+
func (g gitImpl) DeletedFiles() []FilePath {
85+
return g.DeletedFilesList
8686
}
8787

88-
func (g gitImpl) GetCommits() []GitCommit {
89-
return g.Commits
88+
func (g gitImpl) Commits() []GitCommit {
89+
return g.CommitsList
9090
}
9191

9292
// FileDiff represents the changes in a file.
@@ -282,82 +282,82 @@ type settingsImpl struct {
282282
BaseURL string `json:"baseURL"`
283283
AdditionalHeaders any `json:"additionalHeaders"`
284284
} `json:"github"`
285-
CLIArgs CLIArgs `json:"cliArgs"`
285+
CLIArgsData CLIArgs `json:"cliArgs"`
286286
}
287287

288-
// GetGitHubAccessToken returns the GitHub access token
289-
func (s settingsImpl) GetGitHubAccessToken() string {
288+
// GitHubAccessToken returns the GitHub access token
289+
func (s settingsImpl) GitHubAccessToken() string {
290290
return s.GitHub.AccessToken
291291
}
292292

293-
func (s settingsImpl) GetGitHubBaseURL() string {
293+
func (s settingsImpl) GitHubBaseURL() string {
294294
return s.GitHub.BaseURL
295295
}
296296

297-
func (s settingsImpl) GetGitHubAdditionalHeaders() any {
297+
func (s settingsImpl) GitHubAdditionalHeaders() any {
298298
return s.GitHub.AdditionalHeaders
299299
}
300300

301-
func (s settingsImpl) GetCLIArgs() CLIArgs {
302-
return s.CLIArgs
301+
func (s settingsImpl) CLIArgs() CLIArgs {
302+
return s.CLIArgsData
303303
}
304304

305305
// gitHubImpl is the internal implementation of the GitHub interface
306306
type gitHubImpl struct {
307-
Issue GitHubIssue `json:"issue"`
308-
PR GitHubPR `json:"pr"`
309-
ThisPR GitHubAPIPR `json:"thisPR"`
310-
Commits []GitHubCommit `json:"commits"`
311-
Reviews []GitHubReview `json:"reviews"`
312-
RequestedReviewers GitHubReviewers `json:"requested_reviewers"`
307+
IssueData GitHubIssue `json:"issue"`
308+
PRData GitHubPR `json:"pr"`
309+
ThisPRData GitHubAPIPR `json:"thisPR"`
310+
CommitsList []GitHubCommit `json:"commits"`
311+
ReviewsList []GitHubReview `json:"reviews"`
312+
RequestedReviewersData GitHubReviewers `json:"requested_reviewers"`
313313
}
314314

315-
func (g gitHubImpl) GetIssue() GitHubIssue {
316-
return g.Issue
315+
func (g gitHubImpl) Issue() GitHubIssue {
316+
return g.IssueData
317317
}
318318

319-
func (g gitHubImpl) GetPR() GitHubPR {
320-
return g.PR
319+
func (g gitHubImpl) PR() GitHubPR {
320+
return g.PRData
321321
}
322322

323-
func (g gitHubImpl) GetThisPR() GitHubAPIPR {
324-
return g.ThisPR
323+
func (g gitHubImpl) ThisPR() GitHubAPIPR {
324+
return g.ThisPRData
325325
}
326326

327-
func (g gitHubImpl) GetCommits() []GitHubCommit {
328-
return g.Commits
327+
func (g gitHubImpl) Commits() []GitHubCommit {
328+
return g.CommitsList
329329
}
330330

331-
func (g gitHubImpl) GetReviews() []GitHubReview {
332-
return g.Reviews
331+
func (g gitHubImpl) Reviews() []GitHubReview {
332+
return g.ReviewsList
333333
}
334334

335-
func (g gitHubImpl) GetRequestedReviewers() GitHubReviewers {
336-
return g.RequestedReviewers
335+
func (g gitHubImpl) RequestedReviewers() GitHubReviewers {
336+
return g.RequestedReviewersData
337337
}
338338

339339
// gitLabImpl is the internal implementation of the GitLab interface
340340
type gitLabImpl struct {
341-
Metadata RepoMetaData `json:"Metadata"`
342-
MR GitLabMR `json:"mr"`
343-
Commits []GitLabMRCommit `json:"commits"`
344-
Approvals GitLabApproval `json:"approvals"`
341+
MetadataData RepoMetaData `json:"Metadata"`
342+
MRData GitLabMR `json:"mr"`
343+
CommitsList []GitLabMRCommit `json:"commits"`
344+
ApprovalsData GitLabApproval `json:"approvals"`
345345
}
346346

347-
func (g gitLabImpl) GetMetadata() RepoMetaData {
348-
return g.Metadata
347+
func (g gitLabImpl) Metadata() RepoMetaData {
348+
return g.MetadataData
349349
}
350350

351-
func (g gitLabImpl) GetMR() GitLabMR {
352-
return g.MR
351+
func (g gitLabImpl) MR() GitLabMR {
352+
return g.MRData
353353
}
354354

355-
func (g gitLabImpl) GetCommits() []GitLabMRCommit {
356-
return g.Commits
355+
func (g gitLabImpl) Commits() []GitLabMRCommit {
356+
return g.CommitsList
357357
}
358358

359-
func (g gitLabImpl) GetApprovals() GitLabApproval {
360-
return g.Approvals
359+
func (g gitLabImpl) Approvals() GitLabApproval {
360+
return g.ApprovalsData
361361
}
362362

363363
// DSLData is used for JSON unmarshaling, with concrete types

0 commit comments

Comments
 (0)