Skip to content

Commit 488c5a1

Browse files
authored
fix: coinbase wallet extension bug (rainbow-me#657)
1 parent e839b9d commit 488c5a1

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

.changeset/silent-tomatoes-join.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@rainbow-me/rainbowkit': patch
3+
---
4+
5+
Fix error on desktop where selecting Coinbase Wallet while extension was installed would show you the wrong copy.

packages/rainbowkit/src/components/ConnectOptions/ConnectDetails.tsx

+4-2
Original file line numberDiff line numberDiff line change
@@ -176,14 +176,16 @@ export function ConnectDetail({
176176
label: 'OPEN',
177177
onClick: showWalletConnectModal,
178178
}
179-
: qrCode
179+
: qrCode && qrCodeUri
180180
? {
181181
description: `Don\u2019t have the ${name} app?`,
182182
label: 'GET',
183183
onClick: () => changeWalletStep(WalletStep.Download),
184184
}
185185
: {
186-
description: `Confirm connection in ${shortName || name}`,
186+
description: `Confirm connection in ${
187+
compactModeEnabled ? shortName || name : name
188+
}`,
187189
label: 'RETRY',
188190
onClick: getDesktopDeepLink
189191
? async () => {

packages/rainbowkit/src/components/ConnectOptions/DesktopOptions.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export function DesktopOptions({ onClose }: { onClose: () => void }) {
5050
>();
5151
const [selectedWallet, setSelectedWallet] = useState<WalletConnector>();
5252
const [qrCodeUri, setQrCodeUri] = useState<string>();
53-
const hasQrCode = !!selectedWallet?.qrCode;
53+
const hasQrCode = !!selectedWallet?.qrCode && qrCodeUri;
5454
const [connectionError, setConnectionError] = useState(false);
5555
const modalSize = useContext(ModalSizeContext);
5656
const compactModeEnabled = modalSize === ModalSizeOptions.COMPACT;

0 commit comments

Comments
 (0)