test: check container creation with resource limits and node task slots

Author: danpasecinic

internal/types/node_test.go

@@ -0,0 +1,96 @@
+package types
+
+import "testing"
+
+func TestNode_GetMaxTaskSlots(t *testing.T) {
+	tests := []struct {
+		name      string
+		node      Node
+		wantSlots int
+	}{
+		{
+			name: "nil resources returns default 10",
+			node: Node{
+				NodeID:    "node1",
+				Resources: nil,
+			},
+			wantSlots: 10,
+		},
+		{
+			name: "CPU is limiting factor",
+			node: Node{
+				NodeID: "node2",
+				Resources: &NodeResources{
+					Capacity: ResourceList{
+						CPU:    2000,                    // 2 cores
+						Memory: 10 * 1024 * 1024 * 1024, // 10GB
+					},
+				},
+			},
+			wantSlots: 2,
+		},
+		{
+			name: "Memory is limiting factor",
+			node: Node{
+				NodeID: "node3",
+				Resources: &NodeResources{
+					Capacity: ResourceList{
+						CPU:    10000,                  // 10 cores
+						Memory: 2 * 1024 * 1024 * 1024, // 2GB
+					},
+				},
+			},
+			wantSlots: 2,
+		},
+		{
+			name: "Equal CPU and memory",
+			node: Node{
+				NodeID: "node4",
+				Resources: &NodeResources{
+					Capacity: ResourceList{
+						CPU:    4000,                   // 4 cores
+						Memory: 4 * 1024 * 1024 * 1024, // 4GB
+					},
+				},
+			},
+			wantSlots: 4,
+		},
+		{
+			name: "Zero CPU",
+			node: Node{
+				NodeID: "node5",
+				Resources: &NodeResources{
+					Capacity: ResourceList{
+						CPU:    0,
+						Memory: 10 * 1024 * 1024 * 1024,
+					},
+				},
+			},
+			wantSlots: 0,
+		},
+		{
+			name: "Zero Memory",
+			node: Node{
+				NodeID: "node6",
+				Resources: &NodeResources{
+					Capacity: ResourceList{
+						CPU:    10000,
+						Memory: 0,
+					},
+				},
+			},
+			wantSlots: 0,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(
+			tt.name, func(t *testing.T) {
+				got := tt.node.GetMaxTaskSlots()
+				if got != tt.wantSlots {
+					t.Errorf("GetMaxTaskSlots() = %v, want %v", got, tt.wantSlots)
+				}
+			},
+		)
+	}
+}

internal/worker/docker/client_test.go

@@ -129,6 +129,90 @@ func TestCreateContainer(t *testing.T) {
 	}
 }
 
+func TestCreateContainerWithResources(t *testing.T) {
+	client, err := NewClient()
+	if err != nil {
+		t.Skipf("Docker not available: %v", err)
+	}
+	defer func() { _ = client.Close() }()
+
+	ctx := context.Background()
+
+	// Pull alpine first
+	if err := client.PullImage(ctx, "alpine:latest"); err != nil {
+		t.Fatalf("failed to pull alpine image: %v", err)
+	}
+
+	tests := []struct {
+		name        string
+		imageName   string
+		env         []string
+		cpuQuota    float64
+		memoryLimit int64
+		wantErr     bool
+	}{
+		{
+			name:        "create with CPU and memory limits",
+			imageName:   "alpine:latest",
+			env:         []string{"TEST=value"},
+			cpuQuota:    1.0,
+			memoryLimit: 256 * 1024 * 1024, // 256MB
+			wantErr:     false,
+		},
+		{
+			name:        "create with only CPU limit",
+			imageName:   "alpine:latest",
+			env:         []string{},
+			cpuQuota:    0.5,
+			memoryLimit: 0,
+			wantErr:     false,
+		},
+		{
+			name:        "create with only memory limit",
+			imageName:   "alpine:latest",
+			env:         []string{},
+			cpuQuota:    0,
+			memoryLimit: 512 * 1024 * 1024, // 512MB
+			wantErr:     false,
+		},
+		{
+			name:        "create with no limits",
+			imageName:   "alpine:latest",
+			env:         []string{},
+			cpuQuota:    0,
+			memoryLimit: 0,
+			wantErr:     false,
+		},
+		{
+			name:        "create with invalid image",
+			imageName:   "nonexistent-image:latest",
+			env:         []string{},
+			cpuQuota:    1.0,
+			memoryLimit: 256 * 1024 * 1024,
+			wantErr:     true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(
+			tt.name, func(t *testing.T) {
+				containerID, err := client.CreateContainerWithResources(
+					ctx, tt.imageName, tt.env, tt.cpuQuota, tt.memoryLimit,
+				)
+				if (err != nil) != tt.wantErr {
+					t.Errorf("CreateContainerWithResources() error = %v, wantErr %v", err, tt.wantErr)
+				}
+				if !tt.wantErr && containerID == "" {
+					t.Error("CreateContainerWithResources() returned empty container ID")
+				}
+				if containerID != "" {
+					_ = client.RemoveContainer(ctx, containerID)
+				}
+			},
+		)
+	}
+}
+
 func TestStartContainer(t *testing.T) {
 	client, err := NewClient()
 	if err != nil {