feedback - rename DAPR_WF_DISABLE_DETECTION with DAPR_WF_DISABLE_DETERMINISTIC_DETECTION

Signed-off-by: Filinto Duran <[email protected]>

Author: filintod

README.md

@@ -348,12 +348,12 @@ export DAPR_GRPC_PORT=50001
 
 Configure async workflow behavior and debugging:
 
-- `DAPR_WF_DISABLE_DETECTION` - Disable non-determinism detection (set to `true`)
+- `DAPR_WF_DISABLE_DETERMINISTIC_DETECTION` - Disable non-determinism detection (set to `true`)
 
 Example:
 
 ```sh
-export DAPR_WF_DISABLE_DETECTION=false
+export DAPR_WF_DISABLE_DETERMINISTIC_DETECTION=false
 ```
 
 ### Async workflow authoring

durabletask/aio/ASYNCIO_ENHANCEMENTS.md

@@ -143,12 +143,12 @@ Why enable detection (briefly):
 ### Performance Impact
 - `"off"`: Zero overhead (recommended for production)
 - `"best_effort"/"strict"`: ~100-200% overhead due to Python tracing
-- Global disable: Set `DAPR_WF_DISABLE_DETECTION=true` environment variable
+- Global disable: Set `DAPR_WF_DISABLE_DETERMINISTIC_DETECTION=true` environment variable
 
 ## Environment Variables
 
 - `DAPR_WF_DEBUG=true` / `DT_DEBUG=true` - Enable debug logging, operation tracking, and non-determinism warnings
-- `DAPR_WF_DISABLE_DETECTION=true` - Globally disable non-determinism detection
+- `DAPR_WF_DISABLE_DETERMINISTIC_DETECTION=true` - Globally disable non-determinism detection
 
 ## Developer Mode
 ## Workflow Metadata and Headers (Async Only)

durabletask/aio/ASYNCIO_INTERNALS.md

@@ -209,7 +209,7 @@ async def my_async_orch(ctx, _):
         ...
 ```
 - Debug gating (best_effort only): set `DAPR_WF_DEBUG=true` (or `DT_DEBUG=true`) to enable full detection; otherwise a no‑op tracer is used to minimize overhead.
-- Global disable (regardless of mode): set `DAPR_WF_DISABLE_DETECTION=true` to force `OFF` behavior without changing code.
+- Global disable (regardless of mode): set `DAPR_WF_DISABLE_DETERMINISTIC_DETECTION=true` to force `OFF` behavior without changing code.
 
 What warnings/errors look like:
 - Warning (`BEST_EFFORT`):
@@ -240,7 +240,7 @@ Quick mapping of alternatives:
 Troubleshooting tips:
 - Seeing repeated warnings? They are deduplicated per callsite; different files/lines will warn independently
 - Unexpected strict errors during replay? Confirm you are not creating background tasks (`asyncio.create_task`) or performing I/O in the orchestrator
-- Need to quiet a test temporarily? Use `sandbox_mode=SandboxMode.OFF` for that orchestrator or `DAPR_WF_DISABLE_DETECTION=true` during the run
+- Need to quiet a test temporarily? Use `sandbox_mode=SandboxMode.OFF` for that orchestrator or `DAPR_WF_DISABLE_DETERMINISTIC_DETECTION=true` during the run
 
 ## Integration with Generator Runtime
 

durabletask/aio/context.py

@@ -90,7 +90,7 @@ def __init__(self, base_ctx: dt_task.OrchestrationContext):
         self._sandbox_mode: Optional[str] = None
 
         # Performance optimization: Check if detection should be globally disabled
-        self._detection_disabled = os.getenv("DAPR_WF_DISABLE_DETECTION") == "true"
+        self._detection_disabled = os.getenv("DAPR_WF_DISABLE_DETERMINISTIC_DETECTION") == "true"
 
     # Core properties from base context
     @property

durabletask/aio/sandbox.py

@@ -35,7 +35,7 @@
 from .errors import NonDeterminismWarning, SandboxViolationError
 
 # Capture environment variable at module load to avoid triggering non-determinism detection
-_DISABLE_DETECTION = os.getenv("DAPR_WF_DISABLE_DETECTION") == "true"
+_DISABLE_DETECTION = os.getenv("DAPR_WF_DISABLE_DETERMINISTIC_DETECTION") == "true"
 
 
 class SandboxMode(str, Enum):

tests/README.md

@@ -116,7 +116,7 @@ export DAPR_WF_DEBUG=true
 export DT_DEBUG=true
 
 # Disable non-determinism detection globally
-export DAPR_WF_DISABLE_DETECTION=true
+export DAPR_WF_DISABLE_DETERMINISTIC_DETECTION=true
 ```
 
 ## Running Specific Test Suites

tests/aio/test_context.py

@@ -468,7 +468,7 @@ def test_detection_disabled_property(self):
         from unittest.mock import patch
 
         # Test with environment variable
-        with patch.dict(os.environ, {"DAPR_WF_DISABLE_DETECTION": "true"}):
+        with patch.dict(os.environ, {"DAPR_WF_DISABLE_DETERMINISTIC_DETECTION": "true"}):
             disabled_ctx = AsyncWorkflowContext(self.mock_base_ctx)
             assert disabled_ctx._detection_disabled == True
 

tests/aio/test_sandbox.py

@@ -612,7 +612,7 @@ async def dummy():
 
     @pytest.mark.asyncio
     async def test_env_disable_detection_allows_create_task(self):
-        """DAPR_WF_DISABLE_DETECTION=true forces mode off; create_task allowed."""
+        """DAPR_WF_DISABLE_DETERMINISTIC_DETECTION=true forces mode off; create_task allowed."""
         import durabletask.aio.sandbox as sandbox_module
         from durabletask.aio import AsyncWorkflowContext
 
@@ -632,7 +632,7 @@ async def quick():
                 assert await t == "ok"
 
     def test_sandbox_scope_global_disable_env_var(self):
-        """Test that DAPR_WF_DISABLE_DETECTION environment variable works."""
+        """Test that DAPR_WF_DISABLE_DETERMINISTIC_DETECTION environment variable works."""
         import durabletask.aio.sandbox as sandbox_module
 
         original_random = random.random